xfa/fxfa/app/xfa_ffdoc.cpp - Issue 2539203002: Convert loose FX_Create* functions into static methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/app/xfa_ffdoc.cpp

Issue 2539203002: Convert loose FX_Create* functions into static methods (Closed)

Patch Set: last batch Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/app/xfa_ffdoc.cpp

diff --git a/xfa/fxfa/app/xfa_ffdoc.cpp b/xfa/fxfa/app/xfa_ffdoc.cpp

index 1b5665bb082173d21f4e212f37b5613980f5810f..cf5b28961360ed388fa337131bb77588ae05049f 100644

--- a/xfa/fxfa/app/xfa_ffdoc.cpp

+++ b/xfa/fxfa/app/xfa_ffdoc.cpp

@@ -417,8 +417,8 @@ CFX_DIBitmap* CXFA_FFDoc::GetPDFNamedImage(const CFX_WideStringC& wsName,

CPDF_StreamAcc streamAcc;

streamAcc.LoadAllData(pStream);

- IFX_SeekableReadStream* pImageFileRead =

- FX_CreateMemoryStream((uint8_t*)streamAcc.GetData(), streamAcc.GetSize());

+ IFX_SeekableReadStream* pImageFileRead = IFX_MemoryStream::Create(

+ (uint8_t*)streamAcc.GetData(), streamAcc.GetSize());

CFX_DIBitmap* pDibSource = XFA_LoadImageFromBuffer(

pImageFileRead, FXCODEC_IMAGE_UNKNOWN, iImageXDpi, iImageYDpi);