Add comment about same-page navs to WCO::DidStart/FinishNavigation

Add comment about same-page navs to WCO::DidStart/FinishNavigation

This CL updates the description of
WebContentsObserver::DidStartNavigation and
WebContentsObserver::DidFinishNavigation to remind implementers that
they will also be called on same-page navigations. Note that this is the
main difference between WebContentsObserver::DidStartNavigation and
WebContentsObserver::DidStartProvisionalLoad in non-PlzNavigate
behavior.

BUG=667256
Committed: https://crrev.com/57f99bd2aed3c3b5ea06f44ae7b8c42ff687481f
Cr-Commit-Position: refs/heads/master@{#435343}

[clamy, 2016-11-30 17:17:46]

Description was changed from

==========
Add comment about same-page navs to WCO::DidStart/FinishNavigation

This CL updates the description of
WebContentsObserver::DidStartNavigation and
WebContentsObserver::DidFinishNavigation to remind implementers that
they will also be called on same-page navigations. Note that this is the
main difference between WebContentsObserver::DidStartNavigation and
WebContentsObserver::DidStartProvisionalLoad in non-PlzNavigate
behavior.

BUG=667256
==========

to

==========
Add comment about same-page navs to WCO::DidStart/FinishNavigation

This CL updates the description of
WebContentsObserver::DidStartNavigation and
WebContentsObserver::DidFinishNavigation to remind implementers that
they will also be called on same-page navigations. Note that this is the
main difference between WebContentsObserver::DidStartNavigation and
WebContentsObserver::DidStartProvisionalLoad in non-PlzNavigate
behavior.

BUG=667256
==========

[clamy, 2016-11-30 17:17:47]

clamy@chromium.org changed reviewers:
+ nasko@chromium.org

[clamy, 2016-11-30 17:18:29]

@nasko: PTAL. Following the location tracking bug, I think it's a good idea to
include a warning about same-page navigations to WCO::DidStartNavigation.

[nasko, 2016-11-30 17:22:12]

Small nit, otherwise LGTM. Thanks for adding the comment!

https://codereview.chromium.org/2539193002/diff/1/content/public/browser/web_...
File content/public/browser/web_contents_observer.h (right):

https://codereview.chromium.org/2539193002/diff/1/content/public/browser/web_...
content/public/browser/web_contents_observer.h:147: // navigations or pushState,
which will not result in a document change. To
nit: pushState/replaceState.

[clamy, 2016-11-30 17:26:13]

Thanks!

https://codereview.chromium.org/2539193002/diff/1/content/public/browser/web_...
File content/public/browser/web_contents_observer.h (right):

https://codereview.chromium.org/2539193002/diff/1/content/public/browser/web_...
content/public/browser/web_contents_observer.h:147: // navigations or pushState,
which will not result in a document change. To
On 2016/11/30 17:22:12, nasko wrote:
> nit: pushState/replaceState.

Done.

[clamy, 2016-11-30 17:26:21]

The CQ bit was checked by clamy@chromium.org

[clamy, 2016-11-30 17:26:21]

The patchset sent to the CQ was uploaded after l-g-t-m from nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/2539193002/#ps20001
(title: "Addressed nit")

[commit-bot: I haz the power, 2016-11-30 17:26:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 18:25:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480526781007560,
"parent_rev": "2981c90feff7d886cf908ad52c2589bf7b32c5d5", "commit_rev":
"9bcfb44df0cdd728fbd54ca84b3242541b5cadb8"}

[commit-bot: I haz the power, 2016-11-30 18:25:41]

Description was changed from

==========
Add comment about same-page navs to WCO::DidStart/FinishNavigation

This CL updates the description of
WebContentsObserver::DidStartNavigation and
WebContentsObserver::DidFinishNavigation to remind implementers that
they will also be called on same-page navigations. Note that this is the
main difference between WebContentsObserver::DidStartNavigation and
WebContentsObserver::DidStartProvisionalLoad in non-PlzNavigate
behavior.

BUG=667256
==========

to

==========
Add comment about same-page navs to WCO::DidStart/FinishNavigation

This CL updates the description of
WebContentsObserver::DidStartNavigation and
WebContentsObserver::DidFinishNavigation to remind implementers that
they will also be called on same-page navigations. Note that this is the
main difference between WebContentsObserver::DidStartNavigation and
WebContentsObserver::DidStartProvisionalLoad in non-PlzNavigate
behavior.

BUG=667256
==========

[commit-bot: I haz the power, 2016-11-30 18:25:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-30 18:31:09]

Description was changed from

==========
Add comment about same-page navs to WCO::DidStart/FinishNavigation

This CL updates the description of
WebContentsObserver::DidStartNavigation and
WebContentsObserver::DidFinishNavigation to remind implementers that
they will also be called on same-page navigations. Note that this is the
main difference between WebContentsObserver::DidStartNavigation and
WebContentsObserver::DidStartProvisionalLoad in non-PlzNavigate
behavior.

BUG=667256
==========

to

==========
Add comment about same-page navs to WCO::DidStart/FinishNavigation

This CL updates the description of
WebContentsObserver::DidStartNavigation and
WebContentsObserver::DidFinishNavigation to remind implementers that
they will also be called on same-page navigations. Note that this is the
main difference between WebContentsObserver::DidStartNavigation and
WebContentsObserver::DidStartProvisionalLoad in non-PlzNavigate
behavior.

BUG=667256

Committed: https://crrev.com/57f99bd2aed3c3b5ea06f44ae7b8c42ff687481f
Cr-Commit-Position: refs/heads/master@{#435343}
==========

[commit-bot: I haz the power, 2016-11-30 18:31:10]

Patchset 2 (id:??) landed as
https://crrev.com/57f99bd2aed3c3b5ea06f44ae7b8c42ff687481f
Cr-Commit-Position: refs/heads/master@{#435343}