Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1403)

Unified Diff: content/public/browser/web_contents_observer.h

Issue 2539193002: Add comment about same-page navs to WCO::DidStart/FinishNavigation (Closed)
Patch Set: Addressed nit Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/web_contents_observer.h
diff --git a/content/public/browser/web_contents_observer.h b/content/public/browser/web_contents_observer.h
index 32a11dd9be3a867304de28a005030d553062d000..5db620927adf80a521d2bf4ab737bfda6e779248 100644
--- a/content/public/browser/web_contents_observer.h
+++ b/content/public/browser/web_contents_observer.h
@@ -143,6 +143,10 @@ class CONTENT_EXPORT WebContentsObserver : public IPC::Listener,
// Note that this is fired by navigations in any frame of the WebContents,
// not just the main frame.
//
+ // Note that this is fired by same-page navigations, such as fragment
+ // navigations or pushState/replaceState, which will not result in a document
+ // change. To filter these out, use NavigationHandle::IsSamePage.
+ //
// Note that more than one navigation can be ongoing in the same frame at the
// same time (including the main frame). Each will get its own
// NavigationHandle.
@@ -178,6 +182,10 @@ class CONTENT_EXPORT WebContentsObserver : public IPC::Listener,
// and related methods to listen for continued events from this
// RenderFrameHost.
//
+ // Note that this is fired by same-page navigations, such as fragment
+ // navigations or pushState/replaceState, which will not result in a document
+ // change. To filter these out, use NavigationHandle::IsSamePage.
+ //
// Note that |navigation_handle| will be destroyed at the end of this call,
// so do not keep a reference to it afterward.
virtual void DidFinishNavigation(NavigationHandle* navigation_handle) {}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698