Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2539183006: Remove RefPtr<ScriptState> from FetchEvent (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
Yuki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, nhiroki, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove RefPtr<ScriptState> from FetchEvent RefPtr<ScriptState> stored in DOM objects has a risk of leaking ScriptStates to unexpected worlds. We should explicitly pass in ScriptState when we need it. BUG=669812 Committed: https://crrev.com/9784a00e2cd70f8828ead651103b5ab22e3c6ac4 Cr-Commit-Position: refs/heads/master@{#435884}

Patch Set 1 #

Total comments: 1

Patch Set 2 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -16 lines) Patch
M third_party/WebKit/Source/modules/serviceworkers/FetchEvent.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp View 3 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
haraken
PTAL
4 years ago (2016-12-02 06:39:30 UTC) #2
Yuki
LGTM as long as you remove m_scriptState. https://codereview.chromium.org/2539183006/diff/1/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.h File third_party/WebKit/Source/modules/serviceworkers/FetchEvent.h (right): https://codereview.chromium.org/2539183006/diff/1/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.h#newcode76 third_party/WebKit/Source/modules/serviceworkers/FetchEvent.h:76: RefPtr<ScriptState> m_scriptState; ...
4 years ago (2016-12-02 06:42:08 UTC) #3
haraken
On 2016/12/02 06:42:08, Yuki wrote: > LGTM as long as you remove m_scriptState. > > ...
4 years ago (2016-12-02 06:55:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539183006/20001
4 years ago (2016-12-02 06:55:49 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-02 08:22:06 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-02 08:25:43 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9784a00e2cd70f8828ead651103b5ab22e3c6ac4
Cr-Commit-Position: refs/heads/master@{#435884}

Powered by Google App Engine
This is Rietveld 408576698