Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Side by Side Diff: third_party/WebKit/Source/modules/serviceworkers/FetchEvent.h

Issue 2539183006: Remove RefPtr<ScriptState> from FetchEvent (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef FetchEvent_h 5 #ifndef FetchEvent_h
6 #define FetchEvent_h 6 #define FetchEvent_h
7 7
8 #include "bindings/core/v8/ScriptPromise.h" 8 #include "bindings/core/v8/ScriptPromise.h"
9 #include "bindings/core/v8/ScriptPromiseProperty.h" 9 #include "bindings/core/v8/ScriptPromiseProperty.h"
10 #include "modules/EventModules.h" 10 #include "modules/EventModules.h"
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 WaitUntilObserver*, 47 WaitUntilObserver*,
48 bool navigationPreloadSent); 48 bool navigationPreloadSent);
49 49
50 Request* request() const; 50 Request* request() const;
51 String clientId() const; 51 String clientId() const;
52 bool isReload() const; 52 bool isReload() const;
53 53
54 void respondWith(ScriptState*, ScriptPromise, ExceptionState&); 54 void respondWith(ScriptState*, ScriptPromise, ExceptionState&);
55 ScriptPromise preloadResponse(ScriptState*); 55 ScriptPromise preloadResponse(ScriptState*);
56 56
57 void onNavigationPreloadResponse(std::unique_ptr<WebServiceWorkerResponse>, 57 void onNavigationPreloadResponse(ScriptState*,
58 std::unique_ptr<WebServiceWorkerResponse>,
58 std::unique_ptr<WebDataConsumerHandle>); 59 std::unique_ptr<WebDataConsumerHandle>);
59 void onNavigationPreloadError(std::unique_ptr<WebServiceWorkerError>); 60 void onNavigationPreloadError(ScriptState*,
61 std::unique_ptr<WebServiceWorkerError>);
60 62
61 const AtomicString& interfaceName() const override; 63 const AtomicString& interfaceName() const override;
62 64
63 DECLARE_VIRTUAL_TRACE(); 65 DECLARE_VIRTUAL_TRACE();
64 66
65 protected: 67 protected:
66 FetchEvent(ScriptState*, 68 FetchEvent(ScriptState*,
67 const AtomicString& type, 69 const AtomicString& type,
68 const FetchEventInit&, 70 const FetchEventInit&,
69 RespondWithObserver*, 71 RespondWithObserver*,
70 WaitUntilObserver*, 72 WaitUntilObserver*,
71 bool navigationPreloadSent); 73 bool navigationPreloadSent);
72 74
73 private: 75 private:
74 RefPtr<ScriptState> m_scriptState; 76 RefPtr<ScriptState> m_scriptState;
Yuki 2016/12/02 06:42:08 Can you remove this line?
75 Member<RespondWithObserver> m_observer; 77 Member<RespondWithObserver> m_observer;
76 Member<Request> m_request; 78 Member<Request> m_request;
77 Member<PreloadResponseProperty> m_preloadResponseProperty; 79 Member<PreloadResponseProperty> m_preloadResponseProperty;
78 String m_clientId; 80 String m_clientId;
79 bool m_isReload; 81 bool m_isReload;
80 }; 82 };
81 83
82 } // namespace blink 84 } // namespace blink
83 85
84 #endif // FetchEvent_h 86 #endif // FetchEvent_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698