Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 253913003: Remove RenderWidgetHostView*::DidUpdateBackingStore. (Closed)

Created:
6 years, 7 months ago by jbauman
Modified:
6 years, 7 months ago
Reviewers:
Tom Sepez, piman
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nasko+codewatch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org
Visibility:
Public.

Description

Remove RenderWidgetHostView*::DidUpdateBackingStore. This isn't necessary anymore with the legacy 2D path gone. Also remove some UpdateRect parameters that aren't used anymore. BUG=362164 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267094

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -212 lines) Patch
M content/browser/frame_host/render_widget_host_view_child_frame.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 2 chunks +0 lines, -27 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 3 chunks +1 line, -14 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 2 2 chunks +0 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 1 chunk +0 lines, -48 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +0 lines, -16 lines 0 comments Download
M content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M content/common/view_messages.h View 1 2 3 2 chunks +0 lines, -23 lines 0 comments Download
M content/port/browser/render_widget_host_view_port.h View 1 chunk +0 lines, -24 lines 0 comments Download
M content/test/test_render_view_host.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
jbauman
6 years, 7 months ago (2014-04-28 20:33:38 UTC) #1
Tom Sepez
Rubberstamp LGTM on deleting message struct members.
6 years, 7 months ago (2014-04-28 20:37:38 UTC) #2
piman
lgtm https://codereview.chromium.org/253913003/diff/1/content/browser/renderer_host/render_widget_host_view_mac.mm File content/browser/renderer_host/render_widget_host_view_mac.mm (left): https://codereview.chromium.org/253913003/diff/1/content/browser/renderer_host/render_widget_host_view_mac.mm#oldcode1025 content/browser/renderer_host/render_widget_host_view_mac.mm:1025: base::Bind(&RenderWidgetHostViewMac::GotSoftwareFrame, Can you remove GotSoftwareFrame too, now?
6 years, 7 months ago (2014-04-28 20:47:52 UTC) #3
jbauman
On 2014/04/28 20:47:52, piman wrote: > lgtm > > https://codereview.chromium.org/253913003/diff/1/content/browser/renderer_host/render_widget_host_view_mac.mm > File content/browser/renderer_host/render_widget_host_view_mac.mm (left): > ...
6 years, 7 months ago (2014-04-28 20:52:37 UTC) #4
piman
On 2014/04/28 20:52:37, jbauman wrote: > On 2014/04/28 20:47:52, piman wrote: > > lgtm > ...
6 years, 7 months ago (2014-04-28 20:55:21 UTC) #5
jbauman
The CQ bit was checked by jbauman@chromium.org
6 years, 7 months ago (2014-04-28 20:56:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/253913003/1
6 years, 7 months ago (2014-04-28 20:57:06 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 21:10:48 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on android_clang_dbg
6 years, 7 months ago (2014-04-28 21:10:48 UTC) #9
jbauman
The CQ bit was checked by jbauman@chromium.org
6 years, 7 months ago (2014-04-28 21:42:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/253913003/20001
6 years, 7 months ago (2014-04-28 21:43:51 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 21:48:48 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on android_clang_dbg tryserver.chromium on linux_chromium_chromeos_clang_dbg tryserver.chromium on linux_chromium_chromeos_rel ...
6 years, 7 months ago (2014-04-28 21:48:48 UTC) #13
jbauman
The CQ bit was checked by jbauman@chromium.org
6 years, 7 months ago (2014-04-28 23:03:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/253913003/40001
6 years, 7 months ago (2014-04-28 23:04:54 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 23:09:55 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_gn_rel
6 years, 7 months ago (2014-04-28 23:09:56 UTC) #17
jbauman
The CQ bit was checked by jbauman@chromium.org
6 years, 7 months ago (2014-04-29 00:20:11 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/253913003/40001
6 years, 7 months ago (2014-04-29 00:21:07 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 01:13:07 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 7 months ago (2014-04-29 01:13:08 UTC) #21
jbauman
The CQ bit was checked by jbauman@chromium.org
6 years, 7 months ago (2014-04-29 19:47:51 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/253913003/60001
6 years, 7 months ago (2014-04-29 19:48:21 UTC) #23
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 05:39:21 UTC) #24
Message was sent while issue was closed. 
Change committed as 267094

Powered by Google App Engine
This is Rietveld 408576698