[runtime] Port simple String.prototype.indexOf cases to TF Builtin

[runtime] Port simple String.prototype.indexOf cases to TF Builtin

Many websites use simple calls to String.prototype.indexOf with either a
one character ASCII needle or needles bigger than the search string. This
CL adds a TFJ builtin for these simple cases, giving up to factor 5 speedup.

Drive-by-fix: Add default Object type to Arguments.at

BUG=

Review-Url: https://codereview.chromium.org/2539093002
Cr-Commit-Position: refs/heads/master@{#41760}
Committed: https://chromium.googlesource.com/v8/v8/+/89f159b0420d643ecc78d43db0f7836d3c4aa932

[Camillo Bruni, 2016-11-30 11:57:14]

Description was changed from

==========
[runtime] Port simple String.prototype.indexOf cases to TF Builtin

Many websites use simple calls to String.prototype.indexOf with either a
one character ASCII needle or needles bigger than the search string. This
CL adds a TFJ builtin for these simple cases, giving up to factor 5 speedup.

BUG=
==========

to

==========
[runtime] Port simple String.prototype.indexOf cases to TF Builtin

Many websites use simple calls to String.prototype.indexOf with either a
one character ASCII needle or needles bigger than the search string. This
CL adds a TFJ builtin for these simple cases, giving up to factor 5 speedup.

Drive-by-fix: Add default Object type to Arguments.at

BUG=
==========

[Camillo Bruni, 2016-11-30 12:09:10]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 12:09:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 12:36:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 12:36:40]

Dry run: This issue passed the CQ dry run.

[Camillo Bruni, 2016-12-05 16:32:32]

cbruni@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Camillo Bruni, 2016-12-05 16:32:33]

PTAL first round.

https://codereview.chromium.org/2539093002/diff/60001/src/builtins/builtins-s...
File src/builtins/builtins-string.cc (right):

https://codereview.chromium.org/2539093002/diff/60001/src/builtins/builtins-s...
src/builtins/builtins-string.cc:948: GotoIf(IntPtrGreaterThan(string_length,
IntPtrConstant(32)), &call_runtime);
I tried unrolling a loop of 8 and 16 iterations respectively with only minor
improvements.

[Jakob Kummerow, 2016-12-06 06:58:40]

https://codereview.chromium.org/2539093002/diff/60001/src/builtins/builtins-s...
File src/builtins/builtins-string.cc (right):

https://codereview.chromium.org/2539093002/diff/60001/src/builtins/builtins-s...
src/builtins/builtins-string.cc:42: void
BranchIfSimpleOneByteStringInstanceType(Node* instance_type,
high-level comment: using bit masks would probably be faster:

const int kMask = kStringRepresentationMask | kStringEncodingMask;
const int kOneByteSeqString = kSeqStringTag | kOneByteStringTag;
Node* masked = Word32And(instance_type, Int32Constant(kMask));
Branch(Word32Equal(masked, Int32Constant(kOneByteSeqString)), if_true,
if_false);

In fact, you can check two instance types with a single branch if you extend the
above like so:

Word32Equal(Word32And(masked1, Word32Shl(masked2, 2)), 
            Int32Constant((kOneByteSeqString << 8) | kOneByteSeqString)

https://codereview.chromium.org/2539093002/diff/60001/src/builtins/builtins-s...
src/builtins/builtins-string.cc:45: Label if_not_one_byte_internalize(this);
nit: s/internalize/internalized/ (or you can call it "if_not_internalized" if
you like brevity)

https://codereview.chromium.org/2539093002/diff/60001/src/builtins/builtins-s...
src/builtins/builtins-string.cc:46: Branch(IntPtrEqual(instance_type,
This should be either Word32Equal/Int32Constant, or IntPtrEqual/IntPtrConstant,
and matched up with its call sites. Don't mix bit widths!

https://codereview.chromium.org/2539093002/diff/60001/src/builtins/builtins-s...
src/builtins/builtins-string.cc:50: Branch(IntPtrEqual(instance_type,
Int32Constant(ONE_BYTE_STRING_TYPE)),
same

https://codereview.chromium.org/2539093002/diff/60001/src/builtins/builtins-s...
src/builtins/builtins-string.cc:880: // Parameter(0) = nof arguments.
nit: this comment doesn't add anything (and runs the risk of getting stale).

https://codereview.chromium.org/2539093002/diff/60001/src/builtins/builtins-s...
src/builtins/builtins-string.cc:886: Node* const receiver =
arguments.GetReceiver();
Is there a particular reason for the "const" annotations here and below?

https://codereview.chromium.org/2539093002/diff/60001/src/builtins/builtins-s...
src/builtins/builtins-string.cc:939:
BranchIfSimpleOneByteStringInstanceType(instance_type, &check_needle,
How important is the zero_length_needle case?
You have two instance-type branches first, then the zero_length_needle check,
then another two, more restrictive instance-type branches. You could collapse
all four into a single branch (see comment on
BranchIfSimpleOneByteStringInstanceType), at the cost of losing fast-path
support for zero-length needles that happen to have non-one-byte instance types
(not sure if that ever happens).

https://codereview.chromium.org/2539093002/diff/60001/src/builtins/builtins-s...
src/builtins/builtins-string.cc:963: Bind(&loop);
Consider using BuildFastLoop().

https://codereview.chromium.org/2539093002/diff/60001/src/builtins/builtins-s...
src/builtins/builtins-string.cc:966: GotoIf(IntPtrEqual(byte, needle_byte),
&found);
This should probably be Word32Equal.

https://codereview.chromium.org/2539093002/diff/60001/src/code-stub-assembler.h
File src/code-stub-assembler.h (right):

https://codereview.chromium.org/2539093002/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.h:114: // Select the mininum of the two providede IntPtr
values.
nit: s/num/mum/, s/dede/ded/

[Camillo Bruni, 2016-12-06 17:36:44]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 17:36:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 17:38:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 17:38:40]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/17411)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/17469)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/17380)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/30099)
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/18988)
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/19112)

[Camillo Bruni, 2016-12-08 11:19:50]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 11:20:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 11:22:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 11:22:32]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)

[Camillo Bruni, 2016-12-09 14:33:27]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 14:33:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 15:02:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 15:02:06]

Dry run: This issue passed the CQ dry run.

[Camillo Bruni, 2016-12-12 13:51:13]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 13:51:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 13:55:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 13:55:34]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/19241)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/19368)

[Camillo Bruni, 2016-12-12 14:40:54]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 14:41:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 15:09:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 15:09:40]

Dry run: This issue passed the CQ dry run.

[Camillo Bruni, 2016-12-12 15:45:19]

cbruni@chromium.org changed reviewers:
+ ishell@chromium.org

[Camillo Bruni, 2016-12-12 15:45:21]

PTAL "again"

https://codereview.chromium.org/2539093002/diff/60001/src/builtins/builtins-s...
File src/builtins/builtins-string.cc (right):

https://codereview.chromium.org/2539093002/diff/60001/src/builtins/builtins-s...
src/builtins/builtins-string.cc:42: void
BranchIfSimpleOneByteStringInstanceType(Node* instance_type,
On 2016/12/06 at 06:58:40, Jakob Kummerow wrote:
> high-level comment: using bit masks would probably be faster:
> 
> const int kMask = kStringRepresentationMask | kStringEncodingMask;
> const int kOneByteSeqString = kSeqStringTag | kOneByteStringTag;
> Node* masked = Word32And(instance_type, Int32Constant(kMask));
> Branch(Word32Equal(masked, Int32Constant(kOneByteSeqString)), if_true,
if_false);

Replaced with the simpler version to check with the mask for several string
types.
Still keeping the separate branches.

https://codereview.chromium.org/2539093002/diff/60001/src/builtins/builtins-s...
src/builtins/builtins-string.cc:880: // Parameter(0) = nof arguments.
On 2016/12/06 at 06:58:40, Jakob Kummerow wrote:
> nit: this comment doesn't add anything (and runs the risk of getting stale).

removed.

https://codereview.chromium.org/2539093002/diff/60001/src/builtins/builtins-s...
src/builtins/builtins-string.cc:886: Node* const receiver =
arguments.GetReceiver();
On 2016/12/06 at 06:58:40, Jakob Kummerow wrote:
> Is there a particular reason for the "const" annotations here and below?

mostly copy-paste habit, doubt that they will add any value actually :)
Removed them all.

https://codereview.chromium.org/2539093002/diff/60001/src/builtins/builtins-s...
src/builtins/builtins-string.cc:939:
BranchIfSimpleOneByteStringInstanceType(instance_type, &check_needle,
On 2016/12/06 at 06:58:40, Jakob Kummerow wrote:
> How important is the zero_length_needle case?

Not that important, but it's easy enough to implement.

> You have two instance-type branches first, then the zero_length_needle check,
then another two, more restrictive instance-type branches. You could collapse
all four into a single branch (see comment on
BranchIfSimpleOneByteStringInstanceType), at the cost of losing fast-path
support for zero-length needles that happen to have non-one-byte instance types
(not sure if that ever happens).

I've also seen evidence of having too big needle lengths on externalized strings
fairly high up in the list, which was the original motivation to have the
branches separate.

Here the top 20 parameters for string-indexof on our top25 + speedometer:

   1692 indexof receiver_type=EXTERNAL_ONE_BYTE_STRING_TYPE
search_type=STRING_TYPE position=0.000000 receiver_len=1 search_len=9
   1746 indexof receiver_type=EXTERNAL_ONE_BYTE_STRING_TYPE
search_type=ONE_BYTE_STRING_TYPE position=0.000000 receiver_len=1 search_len=10
   1899 indexof receiver_type=EXTERNAL_ONE_BYTE_STRING_TYPE
search_type=STRING_TYPE position=0.000000 receiver_len=1 search_len=8
   2061 indexof receiver_type=EXTERNAL_ONE_BYTE_STRING_TYPE
search_type=ONE_BYTE_STRING_TYPE position=0.000000 receiver_len=1 search_len=9
   2096 indexof receiver_type=EXTERNAL_ONE_BYTE_STRING_TYPE
search_type=STRING_TYPE position=0.000000 receiver_len=2 search_len=4
   2142 indexof receiver_type=SHORT_EXTERNAL_ONE_BYTE_INTERNALIZED_STRING_TYPE
search_type=ONE_BYTE_STRING_TYPE position=0.000000 receiver_len=1 search_len=1
   2205 indexof receiver_type=EXTERNAL_ONE_BYTE_STRING_TYPE
search_type=STRING_TYPE position=0.000000 receiver_len=1 search_len=7
   2304 indexof receiver_type=ONE_BYTE_STRING_TYPE
search_type=ONE_BYTE_STRING_TYPE position=0.000000 receiver_len=29 search_len=3
   2359 indexof receiver_type=ONE_BYTE_INTERNALIZED_STRING_TYPE
search_type=SHORT_EXTERNAL_ONE_BYTE_INTERNALIZED_STRING_TYPE position=0.000000
receiver_len=4 search_len=1
   3258 indexof receiver_type=EXTERNAL_ONE_BYTE_STRING_TYPE
search_type=STRING_TYPE position=0.000000 receiver_len=1 search_len=5
   3405 indexof receiver_type=EXTERNAL_ONE_BYTE_STRING_TYPE
search_type=ONE_BYTE_INTERNALIZED_STRING_TYPE position=0.000000 receiver_len=11
search_len=8
   3456 indexof receiver_type=EXTERNAL_ONE_BYTE_STRING_TYPE
search_type=STRING_TYPE position=0.000000 receiver_len=1 search_len=6
   4583 indexof receiver_type=ONE_BYTE_INTERNALIZED_STRING_TYPE
search_type=ONE_BYTE_INTERNALIZED_STRING_TYPE position=0.000000 receiver_len=2
search_len=1
   4716 indexof receiver_type=EXTERNAL_ONE_BYTE_STRING_TYPE
search_type=STRING_TYPE position=0.000000 receiver_len=1 search_len=4
   8950 indexof receiver_type=ONE_BYTE_STRING_TYPE
search_type=ONE_BYTE_STRING_TYPE position=0.000000 receiver_len=2 search_len=11
   8951 indexof receiver_type=ONE_BYTE_STRING_TYPE
search_type=ONE_BYTE_STRING_TYPE position=0.000000 receiver_len=2 search_len=12
  11316 indexof receiver_type=SHORT_EXTERNAL_ONE_BYTE_INTERNALIZED_STRING_TYPE
search_type=SHORT_EXTERNAL_ONE_BYTE_INTERNALIZED_STRING_TYPE position=0.000000
receiver_len=1 search_len=1
  48364 indexof receiver_type=ONE_BYTE_INTERNALIZED_STRING_TYPE
search_type=ONE_BYTE_STRING_TYPE position=0.000000 receiver_len=42 search_len=1
  62396 indexof receiver_type=ONE_BYTE_INTERNALIZED_STRING_TYPE
search_type=SHORT_EXTERNAL_ONE_BYTE_INTERNALIZED_STRING_TYPE position=0.000000
receiver_len=42 search_len=1
  94056 indexof receiver_type=ONE_BYTE_INTERNALIZED_STRING_TYPE
search_type=ONE_BYTE_INTERNALIZED_STRING_TYPE position=0.000000 receiver_len=42
search_len=1

https://codereview.chromium.org/2539093002/diff/60001/src/code-stub-assembler.h
File src/code-stub-assembler.h (right):

https://codereview.chromium.org/2539093002/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.h:114: // Select the mininum of the two providede IntPtr
values.
On 2016/12/06 at 06:58:40, Jakob Kummerow wrote:
> nit: s/num/mum/, s/dede/ded/

;) done

[Jakob Kummerow, 2016-12-13 02:18:05]

lgtm

[Camillo Bruni, 2016-12-13 13:01:03]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 13:01:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 13:07:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 13:07:49]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)

[Camillo Bruni, 2016-12-15 10:13:50]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 10:14:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 10:19:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 10:19:15]

Dry run: Try jobs failed on following builders:
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[Camillo Bruni, 2016-12-15 12:28:06]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 12:28:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Camillo Bruni, 2016-12-15 14:15:44]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 14:15:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 14:17:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 14:17:24]

Dry run: Try jobs failed on following builders:
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/17923)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/14252)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/30668)

[Camillo Bruni, 2016-12-15 14:28:42]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 14:28:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 14:30:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 14:30:42]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/30674)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/19567)

[Camillo Bruni, 2016-12-15 14:34:26]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 14:34:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 14:39:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 14:39:48]

Dry run: Try jobs failed on following builders:
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)

[Camillo Bruni, 2016-12-15 14:57:58]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 14:58:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 15:04:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 15:05:00]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[Camillo Bruni, 2016-12-15 15:13:54]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 15:13:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 15:40:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 15:40:14]

Dry run: This issue passed the CQ dry run.

[Camillo Bruni, 2016-12-16 09:46:54]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 09:47:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 10:16:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 10:16:26]

Dry run: This issue passed the CQ dry run.

[Camillo Bruni, 2016-12-16 11:32:11]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2016-12-16 11:32:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/2539093002/#ps380001
(title: "merging with master")

[commit-bot: I haz the power, 2016-12-16 11:32:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 11:36:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 11:36:14]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/30784)

[Camillo Bruni, 2016-12-16 12:11:18]

cbruni@chromium.org changed reviewers:
+ jarin@chromium.org

[Camillo Bruni, 2016-12-16 12:11:19]

jarin@ PTAL compiler/*

[Jarin, 2016-12-16 12:28:06]

lgtm for src/compiler/*

[Camillo Bruni, 2016-12-16 13:22:01]

The CQ bit was checked by cbruni@chromium.org

[commit-bot: I haz the power, 2016-12-16 13:22:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 13:24:09]

CQ is committing da patch.

Bot data: {"patchset_id": 380001, "attempt_start_ts": 1481894521597260,
"parent_rev": "63279611b2917f647da70adbf5423f9c4af45fb6", "commit_rev":
"89f159b0420d643ecc78d43db0f7836d3c4aa932"}

[commit-bot: I haz the power, 2016-12-16 13:24:14]

Description was changed from

==========
[runtime] Port simple String.prototype.indexOf cases to TF Builtin

Many websites use simple calls to String.prototype.indexOf with either a
one character ASCII needle or needles bigger than the search string. This
CL adds a TFJ builtin for these simple cases, giving up to factor 5 speedup.

Drive-by-fix: Add default Object type to Arguments.at

BUG=
==========

to

==========
[runtime] Port simple String.prototype.indexOf cases to TF Builtin

Many websites use simple calls to String.prototype.indexOf with either a
one character ASCII needle or needles bigger than the search string. This
CL adds a TFJ builtin for these simple cases, giving up to factor 5 speedup.

Drive-by-fix: Add default Object type to Arguments.at

BUG=

Review-Url: https://codereview.chromium.org/2539093002
Cr-Commit-Position: refs/heads/master@{#41760}
Committed:
https://chromium.googlesource.com/v8/v8/+/89f159b0420d643ecc78d43db0f7836d3c4...
==========

[commit-bot: I haz the power, 2016-12-16 13:24:15]

Committed patchset #20 (id:380001) as
https://chromium.googlesource.com/v8/v8/+/89f159b0420d643ecc78d43db0f7836d3c4...