Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2539083003: [SystemWebViewShellLayoutTest] update expectations to unbreak bots. (Closed)

Created:
4 years ago by whywhat
Modified:
4 years ago
Reviewers:
timvolodine, Yuki
CC:
android-webview-reviews_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[SystemWebViewShellLayoutTest] update expectations to unbreak bots. Update expectations to unbreak Android Webview M bots currently broken due to a change in http://crrev.com/2506393004 See the failure here: https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Webview%20M%20%28dbg%29/builds/16587 BUG=669879 TBR=yukishiino@chromium.org,timvolodine@chromium.org NOTRY=true NOTREECHECK=true Committed: https://crrev.com/16e464ea8835c6b7462a6fde1c09ae70a6cf17ce Cr-Commit-Position: refs/heads/master@{#435428}

Patch Set 1 #

Patch Set 2 : Fixed dependency patchset #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
whywhat
Fixed dependency patchset
4 years ago (2016-11-30 21:43:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539083003/20001
4 years ago (2016-11-30 21:44:26 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-30 21:48:53 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/16e464ea8835c6b7462a6fde1c09ae70a6cf17ce Cr-Commit-Position: refs/heads/master@{#435428}
4 years ago (2016-11-30 21:50:16 UTC) #8
whywhat
4 years ago (2016-11-30 23:22:36 UTC) #9
Message was sent while issue was closed.
This actually wasn't a correct fix, so landing
https://codereview.chromium.org/2541203002 on top.

Powered by Google App Engine
This is Rietveld 408576698