Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2541203002: [SystemWebViewShellLayoutTest] getter onerror is now available in WebView. (Closed)

Created:
4 years ago by whywhat
Modified:
4 years ago
Reviewers:
timvolodine, Yuki
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[SystemWebViewShellLayoutTest] getter onerror is now available in WebView. Update expectations to unbreak Android Webview M bots currently broken due to a change in http://crrev.com/2506393004 See the failure here: https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Webview%20M%20%28dbg%29/builds/16587 BUG=669879 TBR=yukishiino@chromium.org,timvolodine@chromium.org NOTRY=true NOTREECHECK=true Committed: https://crrev.com/c3bdf4c5fe27d793c40c127064de551498a86658 Cr-Commit-Position: refs/heads/master@{#435473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541203002/1
4 years ago (2016-11-30 23:23:27 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 23:29:08 UTC) #4
commit-bot: I haz the power
4 years ago (2016-11-30 23:33:43 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3bdf4c5fe27d793c40c127064de551498a86658
Cr-Commit-Position: refs/heads/master@{#435473}

Powered by Google App Engine
This is Rietveld 408576698