Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2539073002: Remove [ConstructorCallWith=ScriptState] from ShapeDetector (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
Yuki
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove [ConstructorCallWith=ScriptState] from ShapeDetector We want to deprecate [ConstructorCallWith=ScriptState] since it has lead to a programming error that leaks JS objects between worlds (see the bug). This CL replaces [ConstructorCallWith=ScriptState] with [ConstructorCallWith=Document]. BUG=669812 Committed: https://crrev.com/989e930a3f48255272eeca48144c0e744fb47878 Cr-Commit-Position: refs/heads/master@{#435243}

Patch Set 1 #

Patch Set 2 : temp #

Messages

Total messages: 9 (4 generated)
haraken
PTAL
4 years ago (2016-11-30 11:13:33 UTC) #2
Yuki
lgtm
4 years ago (2016-11-30 11:59:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539073002/20001
4 years ago (2016-11-30 11:59:41 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-30 13:49:05 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-30 13:51:49 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/989e930a3f48255272eeca48144c0e744fb47878
Cr-Commit-Position: refs/heads/master@{#435243}

Powered by Google App Engine
This is Rietveld 408576698