third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp - Issue 2539073002: Remove [ConstructorCallWith=ScriptState] from ShapeDetector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp

Issue 2539073002: Remove [ConstructorCallWith=ScriptState] from ShapeDetector (Closed)

Patch Set: temp Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp

diff --git a/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp b/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp

index 620cd8ed1f337c189f00c7b7a8dd6ecc01028568..4a6c8572c9a4d42c17798510ef0efd5cd98cc493 100644

--- a/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp

+++ b/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp

@@ -11,9 +11,9 @@

namespace blink {

-FaceDetector* FaceDetector::create(ScriptState* scriptState,

+FaceDetector* FaceDetector::create(Document& document,

const FaceDetectorOptions& options) {

- return new FaceDetector(*scriptState->domWindow()->frame(), options);

+ return new FaceDetector(*document.frame(), options);

}

FaceDetector::FaceDetector(LocalFrame& frame,