CC Animation: Make AnimationPlayer to be a unit of activation.

CC Animation: Make AnimationPlayer to be a unit of activation.

(Was ElementAnimation previously).
It allows us to avoid inconsistencies in UpdateActivation process and
ElementAnimation's data. Removes redundant last_tick_time_.

As a result, ElementAnimation should become a lightweight passive object which holds
per-Element animation data.

BUG=669755
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/e7592f02242026970af0a6425928e5271a52f79d
Cr-Commit-Position: refs/heads/master@{#435503}

[loyso (OOO), 2016-11-30 04:36:36]

Description was changed from

==========
CC Animation: Make AnimationPlayer to be a unit of activation.

It was ElementAnimation previously.

BUG=669755
==========

to

==========
CC Animation: Make AnimationPlayer to be a unit of activation.

It was ElementAnimation previously.

BUG=669755
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[loyso (OOO), 2016-11-30 04:36:54]

The CQ bit was checked by loyso@chromium.org to run a CQ dry run

[loyso (OOO), 2016-11-30 04:37:06]

loyso@chromium.org changed reviewers:
+ ajuma@chromium.org

[commit-bot: I haz the power, 2016-11-30 04:37:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 04:45:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 04:45:52]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[loyso (OOO), 2016-11-30 05:03:33]

The CQ bit was checked by loyso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 05:04:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 08:33:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 08:33:06]

Dry run: This issue passed the CQ dry run.

[ajuma, 2016-11-30 15:34:53]

lgtm, but please add a sentence or two to the description explaining why we want
AnimationPlayer to be the unit of activation.

https://codereview.chromium.org/2538973002/diff/20001/cc/animation/animation_...
File cc/animation/animation_host.cc (right):

https://codereview.chromium.org/2538973002/diff/20001/cc/animation/animation_...
cc/animation/animation_host.cc:560: void AnimationHost::ActivateAnimationPlayer(
Not related to this CL but something to consider for a future cleanup: we have
two different notions of "Activate" in the animation code:
pending-tree-to-active-tree "activation", and "activation" in the sense of going
from not having any animations to having animations. This is pretty confusing so
it might be worth renaming the latter.

[loyso (OOO), 2016-11-30 23:19:37]

On 2016/11/30 at 15:34:53, ajuma wrote:

> Not related to this CL but something to consider for a future cleanup: we have
two different notions of "Activate" in the animation code:
pending-tree-to-active-tree "activation", and "activation" in the sense of going
from not having any animations to having animations. This is pretty confusing so
it might be worth renaming the latter.
Added this task to the renaming bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=651692

[loyso (OOO), 2016-11-30 23:23:35]

Description was changed from

==========
CC Animation: Make AnimationPlayer to be a unit of activation.

It was ElementAnimation previously.

BUG=669755
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
CC Animation: Make AnimationPlayer to be a unit of activation.

(Was ElementAnimation previously).
It allows us to avoid inconsistencies in UpdateActivation process and
ElementAnimation's data. Removes redundant last_tick_time_.

As a result, ElementAnimation should become a lightweight passive object which
holds
per-Element animation data.

BUG=669755
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[loyso (OOO), 2016-11-30 23:23:51]

On 2016/11/30 at 15:34:53, ajuma wrote:
> lgtm, but please add a sentence or two to the description explaining why we
want AnimationPlayer to be the unit of activation.
Done.

[loyso (OOO), 2016-12-01 00:44:16]

The CQ bit was checked by loyso@chromium.org

[commit-bot: I haz the power, 2016-12-01 00:44:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 00:49:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480553056568700,
"parent_rev": "565d1130119832773d72fdb119ae3f9c4e7f089b", "commit_rev":
"800152da884e41fd7ba74e959667b72a62658fba"}

[commit-bot: I haz the power, 2016-12-01 00:49:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-01 00:52:32]

Description was changed from

==========
CC Animation: Make AnimationPlayer to be a unit of activation.

(Was ElementAnimation previously).
It allows us to avoid inconsistencies in UpdateActivation process and
ElementAnimation's data. Removes redundant last_tick_time_.

As a result, ElementAnimation should become a lightweight passive object which
holds
per-Element animation data.

BUG=669755
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
CC Animation: Make AnimationPlayer to be a unit of activation.

(Was ElementAnimation previously).
It allows us to avoid inconsistencies in UpdateActivation process and
ElementAnimation's data. Removes redundant last_tick_time_.

As a result, ElementAnimation should become a lightweight passive object which
holds
per-Element animation data.

BUG=669755
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/e7592f02242026970af0a6425928e5271a52f79d
Cr-Commit-Position: refs/heads/master@{#435503}
==========

[commit-bot: I haz the power, 2016-12-01 00:52:33]

Patchset 2 (id:??) landed as
https://crrev.com/e7592f02242026970af0a6425928e5271a52f79d
Cr-Commit-Position: refs/heads/master@{#435503}

[loyso (OOO), 2016-12-05 06:06:09]

On 2016/11/30 at 15:34:53, ajuma wrote:
> Not related to this CL but something to consider for a future cleanup: we have
two different notions of "Activate" in the animation code:
pending-tree-to-active-tree "activation", and "activation" in the sense of going
from not having any animations to having animations. This is pretty confusing so
it might be worth renaming the latter.

How about "TickingPlayers" naming? AddToTicking / RemoveFromTicking /
TickingPlayersList / TickPlayers

[ajuma, 2016-12-05 14:05:36]

On 2016/12/05 06:06:09, loyso wrote:
> On 2016/11/30 at 15:34:53, ajuma wrote:
> > Not related to this CL but something to consider for a future cleanup: we
have
> two different notions of "Activate" in the animation code:
> pending-tree-to-active-tree "activation", and "activation" in the sense of
going
> from not having any animations to having animations. This is pretty confusing
so
> it might be worth renaming the latter.
> 
> How about "TickingPlayers" naming? AddToTicking / RemoveFromTicking /
> TickingPlayersList / TickPlayers

sgtm!