Add a cast audio bot.

Add a cast audio bot.

This exercises the is_cast_audio_only=true and enable_webrtc=false
codepaths which periodically break because they are not built.

Corresponding CL at https://chromium-review.googlesource.com/c/452802/

BUG=667546
TEST=`gn gen out_audio/ --args='is_chromecast=true
is_cast_audio_only=true enable_webrtc=false' && ninja -C out_audio/
cast_shell`

Review-Url: https://codereview.chromium.org/2538883003
Cr-Commit-Position: refs/heads/master@{#456222}
Committed: https://chromium.googlesource.com/chromium/src/+/83d2305af8b3143f5c85d9d72c0c392ec88a15ba

[mbjorge, 2016-11-29 22:23:40]

mbjorge@chromium.org changed reviewers:
+ brettw@chromium.org, dpranke@chromium.org, slan@chromium.org

[mbjorge, 2016-11-29 22:28:36]

I am really not familiar with how setting up bots go, so let me know if I need
to touch some more files. This CL is just based on pattern matching with the
current cast bots I could find.

[Dirk Pranke, 2016-12-01 00:38:39]

this lgtm, but as I noted in
https://bugs.chromium.org/p/chromium/issues/detail?id=667546#c1 there's a bunch
of other steps to follow as well.

https://codereview.chromium.org/2538883003/diff/1/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2538883003/diff/1/tools/mb/mb_config.pyl#newc...
tools/mb/mb_config.pyl:256: 'Cast Audio Linux Trusty': 'cast_audio_release_bot',
Is just Trusty enough? Are you expecting 'Cast Audio Linux' to be Precise, and
if so, why do you need to support that?

(We're trying to get everything onto at least Trusty).

[mbjorge, 2016-12-01 01:17:21]

On 2016/12/01 at 00:38:39, dpranke wrote:
> this lgtm, but as I noted in
https://bugs.chromium.org/p/chromium/issues/detail?id=667546#c1 there's a bunch
of other steps to follow as well.
> 
> https://codereview.chromium.org/2538883003/diff/1/tools/mb/mb_config.pyl
> File tools/mb/mb_config.pyl (right):
> 
>
https://codereview.chromium.org/2538883003/diff/1/tools/mb/mb_config.pyl#newc...
> tools/mb/mb_config.pyl:256: 'Cast Audio Linux Trusty':
'cast_audio_release_bot',
> Is just Trusty enough? Are you expecting 'Cast Audio Linux' to be Precise, and
if so, why do you need to support that?
> 
> (We're trying to get everything onto at least Trusty).

Just Trusty is enough; honestly, no preference between Trusty vs Precise vs
something else. I was just matching was was there for cast already.

Do I want to keep the bots that explicitly specify Trusty in the name, or is it
better to use the more general 'Cast Audio Linux' (and presumable they just get
whichever version is available/current)?

[Dirk Pranke, 2016-12-01 01:18:38]

On 2016/12/01 01:17:21, mbjorge wrote:
> Do I want to keep the bots that explicitly specify Trusty in the name, or is
it
> better to use the more general 'Cast Audio Linux' (and presumable they just
get
> whichever version is available/current)?

Just use 'Cast Audio Linux'.

[mbjorge, 2017-03-09 22:04:59]

Description was changed from

==========
Add a cast audio bot.

This exercises the is_cast_audio_only=true and enable_webrtc=false
codepaths which periodically break because they are not built.

BUG=667546
TEST=`gn gen out_audio/ --args='is_chromecast=true
is_cast_audio_only=true enable_webrtc=false' && ninja -C out_audio/
cast_shell`
==========

to

==========
Add a cast audio bot.

This exercises the is_cast_audio_only=true and enable_webrtc=false
codepaths which periodically break because they are not built.

Corresponding CL at https://chromium-review.googlesource.com/c/452802/

BUG=667546
TEST=`gn gen out_audio/ --args='is_chromecast=true
is_cast_audio_only=true enable_webrtc=false' && ninja -C out_audio/
cast_shell`
==========

[mbjorge, 2017-03-09 22:05:18]

Ok, finally getting back on this train

[mbjorge, 2017-03-09 22:10:05]

Do the changes need to land in any particular order, or is ok to commit this CL?

[Dirk Pranke, 2017-03-10 02:14:06]

lgtm.

This CL should land before the build-side CL. In this particular case, the
important thing is not actually when the build-side CL lands, but when the
master is restarted to add the new builder. Once the builder start trying to
build things, it needs to see these changes in the checkout, hence, this should
land first :).

[mbjorge, 2017-03-10 17:47:13]

The CQ bit was checked by mbjorge@chromium.org

[commit-bot: I haz the power, 2017-03-10 17:47:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mbjorge, 2017-03-10 17:47:53]

On 2017/03/10 at 02:14:06, dpranke wrote:
> lgtm.
> 
> This CL should land before the build-side CL. In this particular case, the
important thing is not actually when the build-side CL lands, but when the
master is restarted to add the new builder. Once the builder start trying to
build things, it needs to see these changes in the checkout, hence, this should
land first :).

Gotcha! Thank you

[commit-bot: I haz the power, 2017-03-10 18:50:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 18:50:55]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[mbjorge, 2017-03-10 19:07:47]

The CQ bit was checked by mbjorge@chromium.org

[commit-bot: I haz the power, 2017-03-10 19:08:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 19:45:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 19:45:04]

Failed to apply patch for tools/mb/mb_config.pyl:
While running git apply --index -p1;
  error: patch failed: tools/mb/mb_config.pyl:247
  error: tools/mb/mb_config.pyl: patch does not apply

Patch:       tools/mb/mb_config.pyl
Index: tools/mb/mb_config.pyl
diff --git a/tools/mb/mb_config.pyl b/tools/mb/mb_config.pyl
index
34fb9becf58694097e918a48ded2b8de80df8f0c..15616ea1d6f0241624bea5c4df6fc3b9bf821e11
100644
--- a/tools/mb/mb_config.pyl
+++ b/tools/mb/mb_config.pyl
@@ -247,6 +247,7 @@
       'Blimp Linux (dbg)':
'//build/args/bots/chromium.linux/blimp_linux_dbg.gn',
       'Cast Android (dbg)': 'android_cast_debug_static_bot',
       'Cast Linux': 'cast_release_bot',
+      'Cast Audio Linux': 'cast_audio_release_bot',
       'Linux Builder (dbg)': 'debug_bot',
       'Linux Builder (dbg)(32)': 'debug_bot_x86',
       'Linux Builder': 'release_bot',
@@ -502,6 +503,7 @@
       'Chromium Linux Codesearch Builder': 'codesearch',
       'ChromiumOS Codesearch Builder': 'codesearch',
       'cast_shell_linux': 'cast_release_trybot',
+      'cast_shell_audio_linux': 'cast_audio_release_trybot',
       'chromeos_amd64-generic_chromium_compile_only_ng': 'cros_chrome_sdk',
       'chromeos_daisy_chromium_compile_only_ng': 'cros_chrome_sdk',
       'chromeos_x86-generic_chromium_compile_only_ng': 'cros_chrome_sdk',
@@ -938,6 +940,14 @@
       'cast', 'release_trybot',
     ],
 
+    'cast_audio_release_bot': [
+      'cast', 'cast_audio', 'release_bot',
+    ],
+
+    'cast_audio_release_trybot': [
+      'cast', 'cast_audio', 'release_trybot',
+    ],
+
     'cfi_full_cfi_diag_release_static': [
       'cfi_full', 'cfi_diag', 'release', 'static',
     ],
@@ -1496,6 +1506,10 @@
       'gn_args': 'is_chromecast=true',
     },
 
+    'cast_audio': {
+      'gn_args': 'is_cast_audio_only=true enable_webrtc=false'
+    },
+
     'cfi': {
       'gn_args': 'is_cfi=true',
     },

[mbjorge, 2017-03-10 23:01:49]

The CQ bit was checked by mbjorge@chromium.org

[mbjorge, 2017-03-10 23:01:50]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2538883003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-10 23:02:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 00:08:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489186909522370,
"parent_rev": "616b30a936244b12170072859a0ca988459a6a1b", "commit_rev":
"83d2305af8b3143f5c85d9d72c0c392ec88a15ba"}

[commit-bot: I haz the power, 2017-03-11 00:09:14]

Description was changed from

==========
Add a cast audio bot.

This exercises the is_cast_audio_only=true and enable_webrtc=false
codepaths which periodically break because they are not built.

Corresponding CL at https://chromium-review.googlesource.com/c/452802/

BUG=667546
TEST=`gn gen out_audio/ --args='is_chromecast=true
is_cast_audio_only=true enable_webrtc=false' && ninja -C out_audio/
cast_shell`
==========

to

==========
Add a cast audio bot.

This exercises the is_cast_audio_only=true and enable_webrtc=false
codepaths which periodically break because they are not built.

Corresponding CL at https://chromium-review.googlesource.com/c/452802/

BUG=667546
TEST=`gn gen out_audio/ --args='is_chromecast=true
is_cast_audio_only=true enable_webrtc=false' && ninja -C out_audio/
cast_shell`

Review-Url: https://codereview.chromium.org/2538883003
Cr-Commit-Position: refs/heads/master@{#456222}
Committed:
https://chromium.googlesource.com/chromium/src/+/83d2305af8b3143f5c85d9d72c0c...
==========

[commit-bot: I haz the power, 2017-03-11 00:09:15]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/83d2305af8b3143f5c85d9d72c0c...