Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2538833004:
image_decoder: Delay shutdown on idle (Closed)
|
Created:
4 years ago by Ken Rockot(use gerrit already) Modified:
4 years ago Reviewers:
Ben Goodger (Google) CC:
chromium-reviews, Theresa Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionimage_decoder: Delay shutdown on idle
Instead of immediately tearing down the image_decoder service
once it's idle, wait 5 seconds in case there are going to be
more requests soon.
This mirrors the behavior of utility process image decoding
prior to servicification, and is intended to address latency
issues with multiple image decodes happening in quick (but not
quite immediate) succession.
BUG=669835
Committed: https://crrev.com/0798a4585e6cb5df5e5596b8692656fca669cc28
Committed: https://crrev.com/7132d89aa639d928f4fa72adfac66aebbe660d50
Cr-Original-Commit-Position: refs/heads/master@{#435815}
Cr-Commit-Position: refs/heads/master@{#436113}
Patch Set 1 #Patch Set 2 : . #
Messages
Total messages: 23 (12 generated)
The CQ bit was checked by rockot@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
rockot@chromium.org changed reviewers: + ben@chromium.org
CC +twellington@ and +finnur@ FYI
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Thanks, Ken! I tested this in my local tree and it makes a *huge* difference in performance when decoding a batch of Nexus 6 photos.
lgtm
The CQ bit was checked by rockot@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480638436811830, "parent_rev":
"41be9768f4f7739f30de1b6cd6ba49c9c7889fb5", "commit_rev":
"2846315d404058ec0c8c19a4fc7b0014e98e595e"}
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== image_decoder: Delay shutdown on idle Instead of immediately tearing down the image_decoder service once it's idle, wait 5 seconds in case there are going to be more requests soon. This mirrors the behavior of utility process image decoding prior to servicification, and is intended to address latency issues with multiple image decodes happening in quick (but not quite immediate) succession. BUG=669835 ========== to ========== image_decoder: Delay shutdown on idle Instead of immediately tearing down the image_decoder service once it's idle, wait 5 seconds in case there are going to be more requests soon. This mirrors the behavior of utility process image decoding prior to servicification, and is intended to address latency issues with multiple image decodes happening in quick (but not quite immediate) succession. BUG=669835 Committed: https://crrev.com/0798a4585e6cb5df5e5596b8692656fca669cc28 Cr-Commit-Position: refs/heads/master@{#435815} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/0798a4585e6cb5df5e5596b8692656fca669cc28 Cr-Commit-Position: refs/heads/master@{#435815}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2544313002/ by rockot@chromium.org. The reason for reverting is: I did something stupid. Trivial UAF, will fix..
The CQ bit was checked by rockot@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org Link to the patchset: https://codereview.chromium.org/2538833004/#ps20001 (title: ".")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480718503175140,
"parent_rev": "204c6e9471167a72d7687b8a183e85c7bcdc0fed", "commit_rev":
"a04b60a52308c527ac83abf7488b37b3daa0ab94"}
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== image_decoder: Delay shutdown on idle Instead of immediately tearing down the image_decoder service once it's idle, wait 5 seconds in case there are going to be more requests soon. This mirrors the behavior of utility process image decoding prior to servicification, and is intended to address latency issues with multiple image decodes happening in quick (but not quite immediate) succession. BUG=669835 Committed: https://crrev.com/0798a4585e6cb5df5e5596b8692656fca669cc28 Cr-Commit-Position: refs/heads/master@{#435815} ========== to ========== image_decoder: Delay shutdown on idle Instead of immediately tearing down the image_decoder service once it's idle, wait 5 seconds in case there are going to be more requests soon. This mirrors the behavior of utility process image decoding prior to servicification, and is intended to address latency issues with multiple image decodes happening in quick (but not quite immediate) succession. BUG=669835 Committed: https://crrev.com/0798a4585e6cb5df5e5596b8692656fca669cc28 Committed: https://crrev.com/7132d89aa639d928f4fa72adfac66aebbe660d50 Cr-Original-Commit-Position: refs/heads/master@{#435815} Cr-Commit-Position: refs/heads/master@{#436113} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/7132d89aa639d928f4fa72adfac66aebbe660d50 Cr-Commit-Position: refs/heads/master@{#436113} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
