Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Side by Side Diff: services/image_decoder/image_decoder_service.cc

Issue 2538833004: image_decoder: Delay shutdown on idle (Closed)
Patch Set: . Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « services/image_decoder/image_decoder_service.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "services/image_decoder/image_decoder_service.h" 5 #include "services/image_decoder/image_decoder_service.h"
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/threading/thread_task_runner_handle.h"
9 #include "base/time/time.h"
8 #include "mojo/public/cpp/bindings/strong_binding.h" 10 #include "mojo/public/cpp/bindings/strong_binding.h"
9 #include "services/image_decoder/image_decoder_impl.h" 11 #include "services/image_decoder/image_decoder_impl.h"
10 #include "services/image_decoder/public/interfaces/image_decoder.mojom.h" 12 #include "services/image_decoder/public/interfaces/image_decoder.mojom.h"
11 #include "services/service_manager/public/cpp/interface_registry.h" 13 #include "services/service_manager/public/cpp/interface_registry.h"
12 #include "services/service_manager/public/cpp/service_context.h" 14 #include "services/service_manager/public/cpp/service_context.h"
13 15
14 namespace image_decoder { 16 namespace image_decoder {
15 17
16 namespace { 18 namespace {
17 19
18 void OnConnectionLost(std::unique_ptr<service_manager::ServiceContextRef> ref) { 20 void OnConnectionLost(std::unique_ptr<service_manager::ServiceContextRef> ref) {
19 // No-op. This merely takes ownership of |ref| so it can be destroyed when 21 // No-op. This merely takes ownership of |ref| so it can be destroyed when
20 // this function is invoked. 22 // this function is invoked.
21 } 23 }
22 24
23 void OnImageDecoderRequest( 25 void OnImageDecoderRequest(
24 service_manager::ServiceContextRefFactory* ref_factory, 26 service_manager::ServiceContextRefFactory* ref_factory,
25 mojom::ImageDecoderRequest request) { 27 mojom::ImageDecoderRequest request) {
26 mojo::MakeStrongBinding( 28 mojo::MakeStrongBinding(
27 base::MakeUnique<ImageDecoderImpl>(ref_factory->CreateRef()), 29 base::MakeUnique<ImageDecoderImpl>(ref_factory->CreateRef()),
28 std::move(request)); 30 std::move(request));
29 } 31 }
30 32
31 } // namespace 33 } // namespace
32 34
33 ImageDecoderService::ImageDecoderService() = default; 35 ImageDecoderService::ImageDecoderService() : weak_factory_(this) {}
34 36
35 ImageDecoderService::~ImageDecoderService() = default; 37 ImageDecoderService::~ImageDecoderService() = default;
36 38
37 // static 39 // static
38 std::unique_ptr<service_manager::Service> ImageDecoderService::Create() { 40 std::unique_ptr<service_manager::Service> ImageDecoderService::Create() {
39 return base::MakeUnique<ImageDecoderService>(); 41 return base::MakeUnique<ImageDecoderService>();
40 } 42 }
41 43
42 void ImageDecoderService::OnStart() { 44 void ImageDecoderService::OnStart() {
43 ref_factory_.reset(new service_manager::ServiceContextRefFactory( 45 ref_factory_.reset(new service_manager::ServiceContextRefFactory(
44 base::Bind(&service_manager::ServiceContext::RequestQuit, 46 base::Bind(&ImageDecoderService::MaybeRequestQuitDelayed,
45 base::Unretained(context())))); 47 base::Unretained(this))));
46 } 48 }
47 49
48 bool ImageDecoderService::OnConnect( 50 bool ImageDecoderService::OnConnect(
49 const service_manager::ServiceInfo& remote_info, 51 const service_manager::ServiceInfo& remote_info,
50 service_manager::InterfaceRegistry* registry) { 52 service_manager::InterfaceRegistry* registry) {
51 // Add a reference to the service and tie it to the lifetime of the 53 // Add a reference to the service and tie it to the lifetime of the
52 // InterfaceRegistry's connection. 54 // InterfaceRegistry's connection.
53 std::unique_ptr<service_manager::ServiceContextRef> connection_ref = 55 std::unique_ptr<service_manager::ServiceContextRef> connection_ref =
54 ref_factory_->CreateRef(); 56 ref_factory_->CreateRef();
55 registry->AddConnectionLostClosure( 57 registry->AddConnectionLostClosure(
56 base::Bind(&OnConnectionLost, base::Passed(&connection_ref))); 58 base::Bind(&OnConnectionLost, base::Passed(&connection_ref)));
57 registry->AddInterface( 59 registry->AddInterface(
58 base::Bind(&OnImageDecoderRequest, ref_factory_.get())); 60 base::Bind(&OnImageDecoderRequest, ref_factory_.get()));
59 return true; 61 return true;
60 } 62 }
61 63
62 bool ImageDecoderService::OnStop() { 64 bool ImageDecoderService::OnStop() {
63 return true; 65 return true;
64 } 66 }
65 67
68 void ImageDecoderService::MaybeRequestQuitDelayed() {
69 base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
70 FROM_HERE,
71 base::Bind(&ImageDecoderService::MaybeRequestQuit,
72 weak_factory_.GetWeakPtr()),
73 base::TimeDelta::FromSeconds(5));
74 }
75
76 void ImageDecoderService::MaybeRequestQuit() {
77 DCHECK(ref_factory_);
78 if (ref_factory_->HasNoRefs())
79 context()->RequestQuit();
80 }
81
66 } // namespace image_decoder 82 } // namespace image_decoder
OLDNEW
« no previous file with comments | « services/image_decoder/image_decoder_service.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698