Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1539)

Issue 253883005: Makes change_id unsigned (Closed)

Created:
6 years, 7 months ago by sky
Modified:
6 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Makes change_id unsigned Easier this way for clients to track and not worry about overflow. BUG=none TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266793 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266886

Patch Set 1 #

Patch Set 2 : one more #

Patch Set 3 : merge to trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -45 lines) Patch
M mojo/examples/sample_view_manager_app/sample_view_manager_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 2 chunks +7 lines, -7 lines 0 comments Download
M mojo/services/view_manager/ids.h View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.h View 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection.h View 3 chunks +11 lines, -10 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection_unittest.cc View 1 7 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
sky
6 years, 7 months ago (2014-04-28 21:32:42 UTC) #1
Ben Goodger (Google)
It's not that we don't have to worry about overflow, it's that we don't have ...
6 years, 7 months ago (2014-04-28 21:41:23 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 7 months ago (2014-04-28 22:47:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/253883005/20001
6 years, 7 months ago (2014-04-28 22:48:44 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 23:28:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 7 months ago (2014-04-28 23:28:40 UTC) #6
sky
The CQ bit was checked by sky@chromium.org
6 years, 7 months ago (2014-04-29 00:15:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/253883005/20001
6 years, 7 months ago (2014-04-29 00:16:42 UTC) #8
commit-bot: I haz the power
Change committed as 266793
6 years, 7 months ago (2014-04-29 09:04:10 UTC) #9
Michael Achenbach
A revert of this CL has been created in https://codereview.chromium.org/252143003/ by machenbach@chromium.org. The reason for ...
6 years, 7 months ago (2014-04-29 09:20:17 UTC) #10
sky
I was reverted as the typedef in the test is bogus now (it'll be needed ...
6 years, 7 months ago (2014-04-29 14:53:23 UTC) #11
sky
6 years, 7 months ago (2014-04-29 14:54:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 manually as r266886 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698