Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: mojo/services/public/interfaces/view_manager/view_manager.mojom

Issue 253883005: Makes change_id unsigned (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge to trunk Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/examples/sample_view_manager_app/sample_view_manager_app.cc ('k') | mojo/services/view_manager/ids.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/services/public/interfaces/view_manager/view_manager.mojom
diff --git a/mojo/services/public/interfaces/view_manager/view_manager.mojom b/mojo/services/public/interfaces/view_manager/view_manager.mojom
index 673068cc1a457b773f9052868cdcf7db634aac6b..c5a96a5469c97685db630e6371bd4fe3530c3f76 100644
--- a/mojo/services/public/interfaces/view_manager/view_manager.mojom
+++ b/mojo/services/public/interfaces/view_manager/view_manager.mojom
@@ -23,24 +23,24 @@ interface ViewManager {
// Deletes a node. This does not recurse. Children are removed from the node
// before it is destroyed.
- DeleteNode(uint32 node_id, int32 change_id) => (bool success);
+ DeleteNode(uint32 node_id, uint32 change_id) => (bool success);
// Reparents a node. See description above class for details of |change_id|.
- AddNode(uint32 parent, uint32 child, int32 change_id) => (bool success);
+ AddNode(uint32 parent, uint32 child, uint32 change_id) => (bool success);
// Removes a view from its current parent. See description above class for
// details of |change_id|.
- RemoveNodeFromParent(uint32 node_id, int32 change_id) => (bool success);
+ RemoveNodeFromParent(uint32 node_id, uint32 change_id) => (bool success);
// Creates a new view with the specified id. It is up to the client to ensure
// the id is unique to the connection (the id need not be globally unique).
CreateView(uint16 view_id) => (bool success);
// Deletes the view with the specified id.
- DeleteView(uint32 view_id, int32 change_id) => (bool success);
+ DeleteView(uint32 view_id, uint32 change_id) => (bool success);
// Sets the view a node is showing.
- SetView(uint32 node_id, uint32 view_id, int32 change_id) => (bool success);
+ SetView(uint32 node_id, uint32 view_id, uint32 change_id) => (bool success);
};
[Peer=ViewManager]
@@ -55,14 +55,14 @@ interface ViewManagerClient {
OnNodeHierarchyChanged(uint32 node,
uint32 new_parent,
uint32 old_parent,
- int32 change_id);
+ uint32 change_id);
// Invoked when the view associated with a node is replaced by another view.
// 0 is used to identify a null view.
OnNodeViewReplaced(uint32 node,
uint32 new_view_id,
uint32 old_view_id,
- int32 change_id);
+ uint32 change_id);
};
}
« no previous file with comments | « mojo/examples/sample_view_manager_app/sample_view_manager_app.cc ('k') | mojo/services/view_manager/ids.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698