Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2538723003: Prerender: Hardcode the Silence experiment date (Closed)

Created:
4 years ago by pasko
Modified:
4 years ago
Reviewers:
droger, mattcary
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prerender: Hardcode the Silence experiment date As confirmed with the UMA team, the field trial allows only 60-70% coverage of users for one day (particularly, on Windows). To address this shortcoming, this change hardcodes the explicit date of the experiment (for December 14th as seen in PST, to be synchronized with field trial server-seeding better). To be effective this must be cherry-picked to M55. The experiment still has the ability to serve as a "kill switch" by setting the group "ExperimentYes_expires_2016-12-14T07:00:00Z" (or any earlier date in the string). As discussed above, this has limited effect in the day range. Also this changes AGSA to opt out of the experiment. Currently AGSA only uses ORIGIN_EXTERNAL_REQUEST_FORCED_CELLULAR. The experiment will not take effect on these origins. Other 1st party apps are not using this prerender::Origin, as far as we know, and the use of it is restricted to 1st party, hence this change should not affect the experiment for other Android apps. BUG=640592 Committed: https://crrev.com/40296583e81a52db397a24b2745f43a35ab6870e Cr-Commit-Position: refs/heads/master@{#435610}

Patch Set 1 #

Patch Set 2 : prefix the global with g_ #

Patch Set 3 : allow ORIGIN_EXTERNAL_REQUEST_FORCED_CELLULAR during PrerenderSilence #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -13 lines) Patch
M chrome/browser/prerender/prerender_manager.cc View 1 2 2 chunks +13 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_unittest.cc View 1 2 2 chunks +53 lines, -12 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
pasko
4 years ago (2016-11-29 13:15:00 UTC) #7
mattcary
lgtm
4 years ago (2016-11-29 23:02:40 UTC) #10
pasko
droger: can you please look at it today? I want to get it approved for ...
4 years ago (2016-12-01 13:15:42 UTC) #12
droger
lgtm
4 years ago (2016-12-01 14:06:32 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2538723003/40001
4 years ago (2016-12-01 14:35:46 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-01 15:24:49 UTC) #18
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/40296583e81a52db397a24b2745f43a35ab6870e Cr-Commit-Position: refs/heads/master@{#435610}
4 years ago (2016-12-01 15:28:50 UTC) #20
pasko
4 years ago (2016-12-02 19:10:00 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2546153002/ by pasko@chromium.org.

The reason for reverting is: too late to get it into M55.

Powered by Google App Engine
This is Rietveld 408576698