Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4090)

Unified Diff: chrome/browser/prerender/prerender_manager.cc

Issue 2538723003: Prerender: Hardcode the Silence experiment date (Closed)
Patch Set: allow ORIGIN_EXTERNAL_REQUEST_FORCED_CELLULAR during PrerenderSilence Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/prerender/prerender_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_manager.cc
diff --git a/chrome/browser/prerender/prerender_manager.cc b/chrome/browser/prerender/prerender_manager.cc
index 48300bbae5e5b419ef3ea964014765b13faef654..5655372fc5aa88531d6fa8efb5bc029eaf4fa0da 100644
--- a/chrome/browser/prerender/prerender_manager.cc
+++ b/chrome/browser/prerender/prerender_manager.cc
@@ -1261,8 +1261,10 @@ void PrerenderManager::RecordNetworkBytes(Origin origin,
}
bool PrerenderManager::IsPrerenderSilenceExperiment(Origin origin) const {
- if (origin == ORIGIN_OFFLINE)
+ if (origin == ORIGIN_OFFLINE ||
+ origin == ORIGIN_EXTERNAL_REQUEST_FORCED_CELLULAR) {
return false;
+ }
// The group name should contain expiration time formatted as:
// "ExperimentYes_expires_YYYY-MM-DDTHH:MM:SSZ".
@@ -1271,6 +1273,16 @@ bool PrerenderManager::IsPrerenderSilenceExperiment(Origin origin) const {
const char kExperimentPrefix[] = "ExperimentYes";
if (!base::StartsWith(group_name, kExperimentPrefix,
base::CompareCase::INSENSITIVE_ASCII)) {
+ // The experiment group was not set, use 2016-12-14 PST as the day of the
+ // experiment.
+ base::Time experiment_start;
+ if (!base::Time::FromString("2016-12-14-08:00:00Z", &experiment_start))
+ NOTREACHED();
+ base::Time current_time = GetCurrentTime();
+ if ((experiment_start <= current_time) &&
+ (current_time < experiment_start + base::TimeDelta::FromDays(1))) {
+ return true;
+ }
return false;
}
const char kExperimentPrefixWithExpiration[] = "ExperimentYes_expires_";
« no previous file with comments | « no previous file | chrome/browser/prerender/prerender_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698