Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 2538673002: DevTools: [Console] migrate all of the smallIcons in consoleView.css (Closed)
Patch Set: rebaseline test Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
index 88597110af88c8ef76d1eb1edf023f5a023607dc..d8de5dfaaaf604532f8b18281656f5f5f807d688 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
@@ -1232,7 +1232,9 @@ Console.ConsoleGroupViewMessage = class extends Console.ConsoleViewMessage {
constructor(consoleMessage, linkifier, nestingLevel) {
console.assert(consoleMessage.isGroupStartMessage());
super(consoleMessage, linkifier, nestingLevel);
- this.setCollapsed(consoleMessage.type === SDK.ConsoleMessage.MessageType.StartGroupCollapsed);
+ this._collapsed = consoleMessage.type === SDK.ConsoleMessage.MessageType.StartGroupCollapsed;
+ /** @type {?UI.Icon} */
+ this._expandGroupIcon = null;
}
/**
@@ -1240,8 +1242,8 @@ Console.ConsoleGroupViewMessage = class extends Console.ConsoleViewMessage {
*/
setCollapsed(collapsed) {
this._collapsed = collapsed;
- if (this._element)
- this._element.classList.toggle('collapsed', this._collapsed);
+ if (this._expandGroupIcon)
+ this._expandGroupIcon.setIconType(this._collapsed ? 'smallicon-triangle-right' : 'smallicon-triangle-bottom');
}
/**
@@ -1258,7 +1260,9 @@ Console.ConsoleGroupViewMessage = class extends Console.ConsoleViewMessage {
toMessageElement() {
if (!this._element) {
super.toMessageElement();
- this._element.classList.toggle('collapsed', this._collapsed);
+ this._expandGroupIcon = UI.Icon.create('', 'expand-group-icon');
+ this._contentElement.insertBefore(this._expandGroupIcon, this._contentElement.firstChild);
+ this.setCollapsed(this._collapsed);
}
return this._element;
}

Powered by Google App Engine
This is Rietveld 408576698