Chromium Code Reviews Chromium Code Reviews
Issue 2538653002:
bluetooth: Add sidebar and page manager for chrome://bluetooth-internals. (Closed)
| Index: chrome/browser/resources/bluetooth_internals/bluetooth_internals.html |
| diff --git a/chrome/browser/resources/bluetooth_internals/bluetooth_internals.html b/chrome/browser/resources/bluetooth_internals/bluetooth_internals.html |
| index 6181899737095845cece92ab4cde39afb199ba7a..b6fb1613a2d5725cbe0039aacc6ca91a110584cc 100644 |
| --- a/chrome/browser/resources/bluetooth_internals/bluetooth_internals.html |
| +++ b/chrome/browser/resources/bluetooth_internals/bluetooth_internals.html |
| @@ -6,26 +6,50 @@ |
| <meta charset="utf-8"> |
| <meta name="viewport" content="width=device-width, initial-scale=1"> |
| <title>Bluetooth Internals</title> |
| - <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css"> |
| + <link rel="stylesheet" href="chrome://resources/css/chrome_shared.css"> |
| <link rel="stylesheet" href="bluetooth_internals.css"> |
| + |
| <link rel="import" href="chrome://resources/html/cr/ui.html"> |
| <link rel="import" href="chrome://resources/html/cr/event_target.html"> |
| <link rel="import" href="chrome://resources/html/cr/ui/array_data_model.html"> |
| + <link rel="import" href="chrome://resources/html/cr/ui/focus_outline_manager.html"> |
| + <link rel="import" href="chrome://resources/html/cr/ui/overlay.html"> |
| + <link rel="import" href="chrome://resources/html/cr/ui/page_manager/page_manager.html"> |
| + <link rel="import" href="chrome://resources/html/cr/ui/page_manager/page.html"> |
| <link rel="import" href="chrome://resources/html/util.html"> |
| <script src="interfaces.js"></script> |
| <script src="adapter_broker.js"></script> |
| <script src="device_collection.js"></script> |
| <script src="device_table.js"></script> |
| + <script src="devices_page.js"></script> |
| + <script src="sidebar.js"></script> |
| <script src="bluetooth_internals.js"></script> |
| </head> |
| <body> |
| - <header> |
| - <div class="title"> |
| - Bluetooth Internals |
| - </div> |
| + <header class="page-header"> |
|
ortuno
2016/12/06 10:16:05
q: Why is this outside of page container? If we ke
mbrunson
2016/12/07 01:12:14
Moved. Done.
|
| + <button id="menu-btn" class="custom-appearance"></button> |
| + <h1 class="page-title">Devices</h1> |
|
ortuno
2016/12/06 10:16:05
I can't seem to find where this is being updated?
mbrunson
2016/12/07 01:12:14
The change in structure has thrown a few things of
|
| </header> |
| + <div id="page-container"> |
| + <section id="devices"></section> |
| + </div> |
| + <aside id="sidebar"> |
| + <div class="overlay"></div> |
| + <section class="sidebar-content"> |
| + <header> |
| + <h1>Bluetooth Internals</h1> |
| + </header> |
| + <nav> |
| + <ul role="tablist"> |
| + <li class="selected" data-page-name="devices"> |
| + <button class="custom-appearance">Devices</button> |
| + </li> |
| + </ul> |
| + </nav> |
| + </section> |
| + </aside> |
| </body> |
| <template id="table-template"> |
| @@ -39,7 +63,7 @@ |
| <th data-field="is_gatt_connected">GATT Connection State</th> |
| </tr> |
| </thead> |
| - <tbody class="table-body"> |
| + <tbody> |
| </tbody> |
| </table> |
| </template> |
