chrome/browser/resources/bluetooth_internals/bluetooth_internals.html - Issue 2538653002: bluetooth: Add sidebar and page manager for chrome://bluetooth-internals.

Side by Side Diff: chrome/browser/resources/bluetooth_internals/bluetooth_internals.html

Issue 2538653002: bluetooth: Add sidebar and page manager for chrome://bluetooth-internals. (Closed)

Patch Set: Fix styles, change sidebar class assignment, move page header Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« chrome/browser/resources/bluetooth_internals/bluetooth_internals.css ('K') | « chrome/browser/resources/bluetooth_internals/bluetooth_internals.css ('k') | chrome/browser/resources/bluetooth_internals/bluetooth_internals.js » ('j') | chrome/browser/resources/bluetooth_internals/bluetooth_internals.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <html>	2 <html>

3	3

4 <!-- TODO(crbug.com/658814): Localize strings. -->	4 <!-- TODO(crbug.com/658814): Localize strings. -->

5 <head>	5 <head>

6 <meta charset="utf-8">	6 <meta charset="utf-8">

7 <meta name="viewport" content="width=device-width, initial-scale=1">	7 <meta name="viewport" content="width=device-width, initial-scale=1">

8 <title>Bluetooth Internals</title>	8 <title>Bluetooth Internals</title>

9 <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css">	9 <link rel="stylesheet" href="chrome://resources/css/chrome_shared.css">

10 <link rel="stylesheet" href="bluetooth_internals.css">	10 <link rel="stylesheet" href="bluetooth_internals.css">

	11

11 <link rel="import" href="chrome://resources/html/cr/ui.html">	12 <link rel="import" href="chrome://resources/html/cr/ui.html">

12 <link rel="import" href="chrome://resources/html/cr/event_target.html">	13 <link rel="import" href="chrome://resources/html/cr/event_target.html">

13 <link rel="import" href="chrome://resources/html/cr/ui/array_data_model.html">	14 <link rel="import" href="chrome://resources/html/cr/ui/array_data_model.html">

	15 <link rel="import" href="chrome://resources/html/cr/ui/focus_outline_manager.h tml">

	16 <link rel="import" href="chrome://resources/html/cr/ui/overlay.html">

	17 <link rel="import" href="chrome://resources/html/cr/ui/page_manager/page_manag er.html">

	18 <link rel="import" href="chrome://resources/html/cr/ui/page_manager/page.html" >

14 <link rel="import" href="chrome://resources/html/util.html">	19 <link rel="import" href="chrome://resources/html/util.html">

15	20

16 <script src="interfaces.js"></script>	21 <script src="interfaces.js"></script>

17 <script src="adapter_broker.js"></script>	22 <script src="adapter_broker.js"></script>

18 <script src="device_collection.js"></script>	23 <script src="device_collection.js"></script>

19 <script src="device_table.js"></script>	24 <script src="device_table.js"></script>

	25 <script src="devices_page.js"></script>

	26 <script src="sidebar.js"></script>

20 <script src="bluetooth_internals.js"></script>	27 <script src="bluetooth_internals.js"></script>

21 </head>	28 </head>

22	29

23 <body>	30 <body>

24 <header>	31 <header class="page-header">
	ortuno 2016/12/06 10:16:05 q: Why is this outside of page container? If we ke q: Why is this outside of page container? If we keep it outside then we need to set two rules one for the header and one for the container. mbrunson 2016/12/07 01:12:14 Moved. Done. Show quoted text On 2016/12/06 10:16:05, ortuno wrote: > q: Why is this outside of page container? If we keep it outside then we need to > set two rules one for the header and one for the container. Moved. Done.
25 <div class="title">	32 <button id="menu-btn" class="custom-appearance"></button>

26 Bluetooth Internals	33 <h1 class="page-title">Devices</h1>
	ortuno 2016/12/06 10:16:05 I can't seem to find where this is being updated? I can't seem to find where this is being updated? Would it make sense to use the updateTitle function of the observer? mbrunson 2016/12/07 01:12:14 The change in structure has thrown a few things of Show quoted text On 2016/12/06 10:16:05, ortuno wrote: > I can't seem to find where this is being updated? Would it make sense to use the > updateTitle function of the observer? The change in structure has thrown a few things off here. I've added a PageObserver to bluetooth_internals.js to handle this. Done.
27 </div>

28 </header>	34 </header>

	35 <div id="page-container">

	36 <section id="devices"></section>

	37 </div>

	38 <aside id="sidebar">

	39 <div class="overlay"></div>

	40 <section class="sidebar-content">

	41 <header>

	42 <h1>Bluetooth Internals</h1>

	43 </header>

	44 <nav>

	45 <ul role="tablist">

	46 <li class="selected" data-page-name="devices">

	47 <button class="custom-appearance">Devices</button>

	48 </li>

	49 </ul>

	50 </nav>

	51 </section>

	52 </aside>

29 </body>	53 </body>

30	54

31 <template id="table-template">	55 <template id="table-template">

32 <table>	56 <table>

33 <thead>	57 <thead>

34 <tr>	58 <tr>

35 <th data-field="name_for_display">Name</th>	59 <th data-field="name_for_display">Name</th>

36 <th data-field="address">Address</th>	60 <th data-field="address">Address</th>

37 <th data-field="rssi.value">Latest RSSI</th>	61 <th data-field="rssi.value">Latest RSSI</th>

38 <th data-field="services.length">Services</th>	62 <th data-field="services.length">Services</th>

39 <th data-field="is_gatt_connected">GATT Connection State</th>	63 <th data-field="is_gatt_connected">GATT Connection State</th>

40 </tr>	64 </tr>

41 </thead>	65 </thead>

42 <tbody class="table-body">	66 <tbody>

43 </tbody>	67 </tbody>

44 </table>	68 </table>

45 </template>	69 </template>

46	70

47 </html>	71 </html>

OLD	NEW