Deflake permission dialog + persistence toggle tests on Android.

Deflake permission dialog + persistence toggle tests on Android.

These tests would flake through timing out while waiting for a switch to
be toggled. The toggle was triggered through a synthetic touch event
sent to the switch view. Observing the flake would reveal that the
switch stayed in its original position after the touch event was sent,
so the hypothesis is that the touch event was sent prior to the view
being ready to respond to it.

This CL deflakes the tests by replacing the touch event for triggering
the toggle with an explicit toggle() call on the SwitchCompat object.
This no longer simulates the user input, but the tests should now
reliably pass.

This CL also corrects the arguments used for
MediaTest#testCombinedPersistenceOffDialog to match those of
MediaTest#testMicrophonePersistenceOffDialog.

BUG=662294, 663677, 668700
Committed: https://crrev.com/c6f2275d2d7d1db5d194f46b4d08e37ebb2769b5
Cr-Commit-Position: refs/heads/master@{#435074}

[dominickn, 2016-11-28 23:31:07]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 23:33:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2016-11-29 00:33:30]

dominickn@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[dominickn, 2016-11-29 00:33:30]

PTAL, thanks!

[gone, 2016-11-29 01:10:22]

https://codereview.chromium.org/2538603002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/permissions/PermissionTestCaseBase.java
(right):

https://codereview.chromium.org/2538603002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/permissions/PermissionTestCaseBase.java:230:
persistSwitch.toggle();
1) Can you force this to happen on the UI thread?  Toggling of things should
only happen then.

2) Can this be pulled out so that replyToInfoBarAndWaitForUpdates uses the same
code?  Something like "togglePersistSwitch(View parent, boolean toggleSwitch)"
or something?

[commit-bot: I haz the power, 2016-11-29 01:14:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 01:14:32]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dominickn, 2016-11-29 03:33:59]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 03:34:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 04:17:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 04:17:18]

Dry run: This issue passed the CQ dry run.

[dominickn, 2016-11-29 04:26:51]

Thanks!

https://codereview.chromium.org/2538603002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/permissions/PermissionTestCaseBase.java
(right):

https://codereview.chromium.org/2538603002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/permissions/PermissionTestCaseBase.java:230:
persistSwitch.toggle();
On 2016/11/29 01:10:21, dfalcantara (check my queue) wrote:
> 1) Can you force this to happen on the UI thread?  Toggling of things should
> only happen then.
> 
> 2) Can this be pulled out so that replyToInfoBarAndWaitForUpdates uses the
same
> code?  Something like "togglePersistSwitch(View parent, boolean toggleSwitch)"
> or something?

Done.

[gone, 2016-11-29 18:30:12]

lgtm

[dominickn, 2016-11-29 20:27:14]

The CQ bit was checked by dominickn@chromium.org

[commit-bot: I haz the power, 2016-11-29 20:28:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 20:42:08]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480451234286790,
"parent_rev": "0e97859f25d3f2aec681e39250f13c532d6016fc", "commit_rev":
"551c5c08abff1c647a9db8c026982c05cc32f37f"}

[commit-bot: I haz the power, 2016-11-29 20:42:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-29 20:48:27]

Description was changed from

==========
Deflake permission dialog + persistence toggle tests on Android.

These tests would flake through timing out while waiting for a switch to
be toggled. The toggle was triggered through a synthetic touch event
sent to the switch view. Observing the flake would reveal that the
switch stayed in its original position after the touch event was sent,
so the hypothesis is that the touch event was sent prior to the view
being ready to respond to it.

This CL deflakes the tests by replacing the touch event for triggering
the toggle with an explicit toggle() call on the SwitchCompat object.
This no longer simulates the user input, but the tests should now
reliably pass.

This CL also corrects the arguments used for
MediaTest#testCombinedPersistenceOffDialog to match those of
MediaTest#testMicrophonePersistenceOffDialog.

BUG=662294,663677,668700
==========

to

==========
Deflake permission dialog + persistence toggle tests on Android.

These tests would flake through timing out while waiting for a switch to
be toggled. The toggle was triggered through a synthetic touch event
sent to the switch view. Observing the flake would reveal that the
switch stayed in its original position after the touch event was sent,
so the hypothesis is that the touch event was sent prior to the view
being ready to respond to it.

This CL deflakes the tests by replacing the touch event for triggering
the toggle with an explicit toggle() call on the SwitchCompat object.
This no longer simulates the user input, but the tests should now
reliably pass.

This CL also corrects the arguments used for
MediaTest#testCombinedPersistenceOffDialog to match those of
MediaTest#testMicrophonePersistenceOffDialog.

BUG=662294,663677,668700

Committed: https://crrev.com/c6f2275d2d7d1db5d194f46b4d08e37ebb2769b5
Cr-Commit-Position: refs/heads/master@{#435074}
==========

[commit-bot: I haz the power, 2016-11-29 20:48:27]

Patchset 2 (id:??) landed as
https://crrev.com/c6f2275d2d7d1db5d194f46b4d08e37ebb2769b5
Cr-Commit-Position: refs/heads/master@{#435074}