Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2308)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/permissions/GeolocationTest.java

Issue 2538603002: Deflake permission dialog + persistence toggle tests on Android. (Closed)
Patch Set: Refactor out a method, call toggle() on UI thread Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/permissions/MediaTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/permissions/GeolocationTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/GeolocationTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/GeolocationTest.java
index ebdb604bf32b0ca0b6951dc179fcdfdca2cc34ba..2ac8ac9c331a0bc64788528f6a038328addd72c5 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/GeolocationTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/GeolocationTest.java
@@ -9,7 +9,6 @@ import android.test.suitebuilder.annotation.MediumTest;
import android.test.suitebuilder.annotation.Smoke;
import org.chromium.base.test.util.CommandLineFlags;
-import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.RetryOnFailure;
import org.chromium.chrome.browser.tab.Tab;
@@ -179,7 +178,6 @@ public class GeolocationTest extends PermissionTestCaseBase {
*/
@MediumTest
@CommandLineFlags.Add("enable-features=" + MODAL_TOGGLE_FLAG)
- @DisabledTest(message = "crbug.com/663677") // Flaky.
@Feature({"Location"})
public void testGeolocationPersistenceOffAllowedDialog() throws Exception {
Tab tab = getActivity().getActivityTab();
@@ -219,7 +217,6 @@ public class GeolocationTest extends PermissionTestCaseBase {
*/
@LargeTest
@CommandLineFlags.Add("enable-features=" + MODAL_TOGGLE_FLAG)
- @DisabledTest(message = "crbug.com/662294") // Flaky.
@Feature({"Location"})
public void testGeolocationWatchPersistenceOffAllowedDialog() throws Exception {
runTest("initiate_watchPosition()", 2, true, true, true, true);
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/permissions/MediaTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698