Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2538593002: cc: Force update tile priorities for pending tree tiling set on commit. (Closed)

Created:
4 years ago by sunnyps
Modified:
4 years ago
Reviewers:
vmpstr
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

cc: Force update tile priorities for pending tree tiling set on commit. Forcing |UpdateTilePriorities| for pending tree tiling sets to prevent checkerboarding for cases where compositor is heavily pipelined. In these cases it's possible for a commit to happen after |PrepareTiles| is called during draw. The commit then skips |PrepareTiles| and activates the pending tree causing checkerboarding. |PrepareTiles| is skipped because of a |PictureLayerTilingSet| early out optimization that relies on frame time and viewport to avoid updating tiles. To fix this the tile priorities are always updated on commit. BUG=664007 R=vmpstr@chromium.org TEST=unittest + manual testing on samus CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2529533002 Cr-Commit-Position: refs/heads/master@{#434236} (cherry picked from commit 53fabb1f55e8db09a8bd53ca7af11c2c96667af3) Committed: https://chromium.googlesource.com/chromium/src/+/c42c5358255976cf362d5bda542107bcbef52af6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -3 lines) Patch
M cc/tiles/picture_layer_tiling_set.cc View 1 chunk +8 lines, -3 lines 0 comments Download
M cc/tiles/picture_layer_tiling_set_unittest.cc View 1 chunk +53 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
sunnyps
4 years ago (2016-11-28 23:31:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c42c5358255976cf362d5bda542107bcbef52af6.

Powered by Google App Engine
This is Rietveld 408576698