cc: Force update tile priorities for pending tree tiling set on commit.

cc: Force update tile priorities for pending tree tiling set on commit.

Forcing |UpdateTilePriorities| for pending tree tiling sets to prevent
checkerboarding for cases where compositor is heavily pipelined. In
these cases it's possible for a commit to happen after |PrepareTiles| is
called during draw. The commit then skips |PrepareTiles| and activates
the pending tree causing checkerboarding.

|PrepareTiles| is skipped because of a |PictureLayerTilingSet| early out
optimization that relies on frame time and viewport to avoid updating
tiles. To fix this the tile priorities are always updated on commit.

BUG=664007
R=vmpstr@chromium.org
TEST=unittest + manual testing on samus
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/53fabb1f55e8db09a8bd53ca7af11c2c96667af3
Cr-Commit-Position: refs/heads/master@{#434236}

[sunnyps, 2016-11-23 01:37:11]

Description was changed from

==========
cc: Force update tile priorities for pending tree tiling set on commit.

Forcing |UpdateTilePriorities| for pending tree tiling sets to prevent
checkerboarding for cases where compositor is heavily pipelined. In
these cases it's possible for a commit to happen after |PrepareTiles| is
called during draw. The commit then skips |PrepareTiles| and activates
the pending tree causing checkerboarding.

|PrepareTiles| is skipped because of a |PictureLayerTilingSet| early out
optimization that relies on frame time and viewport to avoid updating
tiles. To fix this the tile priorities are always updated on commit.

BUG=664007
R=vmpstr@chromium.org
TEST=unittest + manual testing on samus
==========

to

==========
cc: Force update tile priorities for pending tree tiling set on commit.

Forcing |UpdateTilePriorities| for pending tree tiling sets to prevent
checkerboarding for cases where compositor is heavily pipelined. In
these cases it's possible for a commit to happen after |PrepareTiles| is
called during draw. The commit then skips |PrepareTiles| and activates
the pending tree causing checkerboarding.

|PrepareTiles| is skipped because of a |PictureLayerTilingSet| early out
optimization that relies on frame time and viewport to avoid updating
tiles. To fix this the tile priorities are always updated on commit.

BUG=664007
R=vmpstr@chromium.org
TEST=unittest + manual testing on samus
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[sunnyps, 2016-11-23 01:37:25]

The CQ bit was checked by sunnyps@chromium.org to run a CQ dry run

[sunnyps, 2016-11-23 01:37:31]

PTAL

[commit-bot: I haz the power, 2016-11-23 01:38:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vmpstr, 2016-11-23 02:08:52]

https://codereview.chromium.org/2529533002/diff/1/cc/tiles/picture_layer_tili...
File cc/tiles/picture_layer_tiling_set.cc (right):

https://codereview.chromium.org/2529533002/diff/1/cc/tiles/picture_layer_tili...
cc/tiles/picture_layer_tiling_set.cc:163:
tiling->Invalidate(layer_invalidation);
Can you leave invalidate in the is active tree case only? Otherwise, it will do
extra unnecessary work.

[sunnyps, 2016-11-23 02:16:07]

PTAL

https://codereview.chromium.org/2529533002/diff/1/cc/tiles/picture_layer_tili...
File cc/tiles/picture_layer_tiling_set.cc (right):

https://codereview.chromium.org/2529533002/diff/1/cc/tiles/picture_layer_tili...
cc/tiles/picture_layer_tiling_set.cc:163:
tiling->Invalidate(layer_invalidation);
On 2016/11/23 02:08:52, vmpstr wrote:
> Can you leave invalidate in the is active tree case only? Otherwise, it will
do
> extra unnecessary work. 

Done.

[vmpstr, 2016-11-23 17:53:48]

lgtm, thanks!

[sunnyps, 2016-11-23 17:54:03]

The CQ bit was checked by sunnyps@chromium.org

[commit-bot: I haz the power, 2016-11-23 17:54:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 20:23:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479923643874100,
"parent_rev": "80578175da4ad98bdd5a1b616bde5dd3785f4cf1", "commit_rev":
"acd77789e3c7de5c2873982da8067638a65124ed"}

[commit-bot: I haz the power, 2016-11-23 20:23:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-23 20:26:18]

Description was changed from

==========
cc: Force update tile priorities for pending tree tiling set on commit.

Forcing |UpdateTilePriorities| for pending tree tiling sets to prevent
checkerboarding for cases where compositor is heavily pipelined. In
these cases it's possible for a commit to happen after |PrepareTiles| is
called during draw. The commit then skips |PrepareTiles| and activates
the pending tree causing checkerboarding.

|PrepareTiles| is skipped because of a |PictureLayerTilingSet| early out
optimization that relies on frame time and viewport to avoid updating
tiles. To fix this the tile priorities are always updated on commit.

BUG=664007
R=vmpstr@chromium.org
TEST=unittest + manual testing on samus
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Force update tile priorities for pending tree tiling set on commit.

Forcing |UpdateTilePriorities| for pending tree tiling sets to prevent
checkerboarding for cases where compositor is heavily pipelined. In
these cases it's possible for a commit to happen after |PrepareTiles| is
called during draw. The commit then skips |PrepareTiles| and activates
the pending tree causing checkerboarding.

|PrepareTiles| is skipped because of a |PictureLayerTilingSet| early out
optimization that relies on frame time and viewport to avoid updating
tiles. To fix this the tile priorities are always updated on commit.

BUG=664007
R=vmpstr@chromium.org
TEST=unittest + manual testing on samus
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/53fabb1f55e8db09a8bd53ca7af11c2c96667af3
Cr-Commit-Position: refs/heads/master@{#434236}
==========

[commit-bot: I haz the power, 2016-11-23 20:26:19]

Patchset 2 (id:??) landed as
https://crrev.com/53fabb1f55e8db09a8bd53ca7af11c2c96667af3
Cr-Commit-Position: refs/heads/master@{#434236}