Make FDF document creation return unique_ptrs

Make FDF document creation return unique_ptrs

Committed: https://pdfium.googlesource.com/pdfium/+/05e01698444726fae302cd335fa4880932d7c543

[Tom Sepez, 2016-11-28 23:09:35]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 23:09:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 23:20:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 23:20:36]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-11-28 23:21:54]

tsepez@chromium.org changed reviewers:
+ npm@chromium.org, weili@chromium.org

[Tom Sepez, 2016-11-28 23:21:55]

Wei, NPM, ready for review.

https://codereview.chromium.org/2538533003/diff/1/fpdfsdk/cpdfsdk_interform.cpp
File fpdfsdk/cpdfsdk_interform.cpp (right):

https://codereview.chromium.org/2538533003/diff/1/fpdfsdk/cpdfsdk_interform.c...
fpdfsdk/cpdfsdk_interform.cpp:466: std::unique_ptr<CFDF_Document> pFDF =
Note:  I can't figure out why this didn't leak and/or get caught in the past. 
Hole in testing?

[Wei Li, 2016-11-29 01:25:34]

lgtm

https://codereview.chromium.org/2538533003/diff/1/fpdfsdk/cpdfsdk_interform.cpp
File fpdfsdk/cpdfsdk_interform.cpp (right):

https://codereview.chromium.org/2538533003/diff/1/fpdfsdk/cpdfsdk_interform.c...
fpdfsdk/cpdfsdk_interform.cpp:466: std::unique_ptr<CFDF_Document> pFDF =
On 2016/11/28 23:21:55, Tom Sepez wrote:
> Note:  I can't figure out why this didn't leak and/or get caught in the past. 
> Hole in testing?

This path is not tested. :(

[Tom Sepez, 2016-11-29 01:29:43]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-11-29 01:29:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 01:30:09]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480382983910240, "parent_rev":
"405ac0f09e1622d7ff3cf60314d290851ac9f7fd", "commit_rev":
"05e01698444726fae302cd335fa4880932d7c543"}

[commit-bot: I haz the power, 2016-11-29 01:30:12]

Description was changed from

==========
Make FDF document creation return unique_ptrs
==========

to

==========
Make FDF document creation return unique_ptrs

Committed:
https://pdfium.googlesource.com/pdfium/+/05e01698444726fae302cd335fa4880932d7...
==========

[commit-bot: I haz the power, 2016-11-29 01:30:13]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/05e01698444726fae302cd335fa4880932d7...