Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2780)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: core/fpdfdoc/cpdf_interform.h

Issue 2538533003: Make FDF document creation return unique_ptrs (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/fpdfapi/parser/cfdf_document.cpp ('k') | core/fpdfdoc/cpdf_interform.cpp » ('j') | fpdfsdk/cpdfsdk_interform.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/fpdfdoc/cpdf_interform.h
diff --git a/core/fpdfdoc/cpdf_interform.h b/core/fpdfdoc/cpdf_interform.h
index fbff0289a1dd9bc7fab33f6d7cb43a6e01f123be..f03ffb1e603b2f9f475ce3495d57562ba5c77865 100644
--- a/core/fpdfdoc/cpdf_interform.h
+++ b/core/fpdfdoc/cpdf_interform.h
@@ -73,12 +73,14 @@ class CPDF_InterForm {
const std::vector<CPDF_FormField*>* fields,
bool bIncludeOrExclude) const;
- CFDF_Document* ExportToFDF(const CFX_WideStringC& pdf_path,
- bool bSimpleFileSpec) const;
- CFDF_Document* ExportToFDF(const CFX_WideStringC& pdf_path,
- const std::vector<CPDF_FormField*>& fields,
- bool bIncludeOrExclude,
- bool bSimpleFileSpec) const;
+ std::unique_ptr<CFDF_Document> ExportToFDF(const CFX_WideStringC& pdf_path,
+ bool bSimpleFileSpec) const;
+
+ std::unique_ptr<CFDF_Document> ExportToFDF(
+ const CFX_WideStringC& pdf_path,
+ const std::vector<CPDF_FormField*>& fields,
+ bool bIncludeOrExclude,
+ bool bSimpleFileSpec) const;
bool ResetForm(const std::vector<CPDF_FormField*>& fields,
bool bIncludeOrExclude,
« no previous file with comments | « core/fpdfapi/parser/cfdf_document.cpp ('k') | core/fpdfdoc/cpdf_interform.cpp » ('j') | fpdfsdk/cpdfsdk_interform.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698