Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 253853002: PlaceHolder in TextArea should allow carriage return and line feed (Closed)

Created:
6 years, 7 months ago by Habib Virji
Modified:
6 years, 7 months ago
Reviewers:
keishi, tkent
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org, ojan
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

PlaceHolder in TextArea should allow carriage return and line feed As per current spec, placeholder should allow carriage return and line feed for text area. While placeholder should strip carriage return and line feed for input type=text. BUG=367632 R=tkent, keishi1 TEST=Placeholder containing CR and LF are not stripped from the text for type text area, while for input type text it is stripped. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173455

Patch Set 1 #

Patch Set 2 : Added rendering test and also added test for carriage return #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/placeholder-appearance-textarea.html View 1 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/placeholder-stripped.html View 1 1 chunk +10 lines, -5 lines 0 comments Download
M LayoutTests/fast/forms/placeholder-stripped-expected.txt View 1 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Habib Virji
Updated as per spec, where text area placeholder should be rendered with CR and LF: ...
6 years, 7 months ago (2014-04-28 15:59:25 UTC) #1
tkent
We should have a rendering test. It should contain CR-only case and LF-only case too.
6 years, 7 months ago (2014-04-29 23:39:02 UTC) #2
Habib Virji
On 2014/04/29 23:39:02, tkent (ooo until May 6) wrote: > We should have a rendering ...
6 years, 7 months ago (2014-05-01 15:56:23 UTC) #3
tkent
lgtm
6 years, 7 months ago (2014-05-07 00:14:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/habib.virji@samsung.com/253853002/20001
6 years, 7 months ago (2014-05-07 00:14:48 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-07 01:22:20 UTC) #6
Message was sent while issue was closed.
Change committed as 173455

Powered by Google App Engine
This is Rietveld 408576698