Source/core/html/HTMLTextAreaElement.cpp - Issue 253853002: PlaceHolder in TextArea should allow carriage return and line feed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLTextAreaElement.cpp

Issue 253853002: PlaceHolder in TextArea should allow carriage return and line feed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added rendering test and also added test for carriage return Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLTextAreaElement.cpp

diff --git a/Source/core/html/HTMLTextAreaElement.cpp b/Source/core/html/HTMLTextAreaElement.cpp

index 35ab21dd8a5ade3aed062df1ebbc65557afb66b4..96bae366d177b42191706527bd5205a5d4040fa8 100644

--- a/Source/core/html/HTMLTextAreaElement.cpp

+++ b/Source/core/html/HTMLTextAreaElement.cpp

@@ -541,7 +541,7 @@ bool HTMLTextAreaElement::matchesReadWritePseudoClass() const

void HTMLTextAreaElement::updatePlaceholderText()

{

HTMLElement* placeholder = placeholderElement();

- String placeholderText = strippedPlaceholder();

+ const AtomicString& placeholderText = fastGetAttribute(placeholderAttr);

if (placeholderText.isEmpty()) {

if (placeholder)

userAgentShadowRoot()->removeChild(placeholder);

« no previous file with comments | « LayoutTests/fast/forms/placeholder-stripped-expected.txt ('k') | no next file » | no next file with comments »