Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2538493007: Revert of [build] Use MSVS 2015 by default. (Closed)

Created:
4 years ago by Michael Achenbach
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [build] Use MSVS 2015 by default. (patchset #5 id:80001 of https://codereview.chromium.org/2533813002/ ) Reason for revert: Breaks CI dbg builder: https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug%20builder/builds/13817 Original issue's description: > [build] Use MSVS 2015 by default. > > BUG=chromium:603131 > LOG=y > > Committed: https://crrev.com/6b9c49cac101d1a373ae1a098b7959f8aff848ac > Cr-Commit-Position: refs/heads/master@{#41407} TBR=jochen@chromium.org,vogelheim@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:603131 Committed: https://crrev.com/48a522b6434907fd6db0a7a1a13333d53d386bea Cr-Commit-Position: refs/heads/master@{#41409}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -109 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M gni/isolate.gni View 1 chunk +1 line, -1 line 0 comments Download
D gypfiles/win/msvs_dependencies.isolate View 1 chunk +0 lines, -97 lines 0 comments Download
M src/base.isolate View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/mb/mb.py View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Michael Achenbach
Created Revert of [build] Use MSVS 2015 by default.
4 years ago (2016-12-01 08:34:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2538493007/1
4 years ago (2016-12-01 08:35:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 08:35:22 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-01 08:35:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48a522b6434907fd6db0a7a1a13333d53d386bea
Cr-Commit-Position: refs/heads/master@{#41409}

Powered by Google App Engine
This is Rietveld 408576698