Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: tools/mb/mb.py

Issue 2538493007: Revert of [build] Use MSVS 2015 by default. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/base.isolate ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/mb/mb.py
diff --git a/tools/mb/mb.py b/tools/mb/mb.py
index d213616911cab2cb8adc1f876c39dde45872ce8d..536dc00fcb16c4148a9f7a0384b55c1b8fc0a850 100755
--- a/tools/mb/mb.py
+++ b/tools/mb/mb.py
@@ -777,13 +777,7 @@
self.WriteFile(gn_runtime_deps_path, '\n'.join(gn_labels) + '\n')
cmd.append('--runtime-deps-list-file=%s' % gn_runtime_deps_path)
- # Override msvs infra environment variables.
- # TODO(machenbach): Remove after GYP_MSVS_VERSION is removed on infra side.
- env = {}
- env.update(os.environ)
- env['GYP_MSVS_VERSION'] = '2015'
-
- ret, _, _ = self.Run(cmd, env=env)
+ ret, _, _ = self.Run(cmd)
if ret:
# If `gn gen` failed, we should exit early rather than trying to
# generate isolates. Run() will have already logged any error output.
« no previous file with comments | « src/base.isolate ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698