tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 41da607a2a839b3ac49e765536be5bbe99f622d7..e52ee035c2b46fb478f3440f272dc3981ae3d910 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -54493,6 +54493,29 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   <summary>Time to store one of the PrefixSet files.</summary>
 </histogram>
 
+<histogram name="SB2.ReferrerAttributionResult"

[Nathan Parker, 2016/12/05 22:21:24]

I'm trying to not put anything new+substantial in the "SB2" prefix, and instead
using "SafeBrowsing" prefix.

[Jialiu Lin, 2016/12/06 23:10:07]

Done.

+    units="SB2AttributionResultTypes">
+  <owner>jialiul@chromium.org</owner>
+  <summary>
+    The result of referrer attribution, including different types of success or

[Nathan Parker, 2016/12/05 22:21:24]

Add some notes to both on _when_ this is incremented -- e.g. when a download is
completed, when a SB interstitial is shown (or is it just when a ping is
generated?).  Maybe these extra desc's should go down in the <suffix>'s... I
think you can add summaries to those (?).

[Jialiu Lin, 2016/12/06 23:10:07]

Done.

+    failure.
+  </summary>
+</histogram>
+
+<histogram name="SB2.ReferrerHasInvalidTabID" units="BooleanInvalid">
+  <owner>jialiul@chromium.org</owner>
+  <summary>
+    Number of times referrer attribution encounters an invalid tab ID.
+  </summary>
+</histogram>
+
+<histogram name="SB2.ReferrerURLChainSize">
+  <owner>jialiul@chromium.org</owner>
+  <summary>
+    The size of referrer URL chain we get from referrer attribution.
+  </summary>
+</histogram>
+
 <histogram name="SB2.RemoteCall.CanCheckUrl" enum="BooleanCanCheckUrl">
   <owner>nparker@chromium.org</owner>
   <summary>
@@ -99854,6 +99877,14 @@ value.
   <int value="2" label="DONT_REMEMBER_PASSWORD"/>
 </enum>
 
+<enum name="SB2AttributionResultTypes" type="int">
+  <int value="0" label="SUCCESS"/>
+  <int value="1" label="SUCCESS_LANDING_PAGE"/>
+  <int value="2" label="SUCCESS_LANDING_REFERRER"/>
+  <int value="3" label="INVALID_URL"/>
+  <int value="4" label="NAVIGATION_EVENT_NOT_FOUND"/>
+</enum>
+
 <enum name="SB2BloomFailure" type="int">
   <obsolete>
     Bloom filter support deleted in October 2012.
@@ -112204,6 +112235,19 @@ value.
   <affected-histogram name="Renderer4.ImageDecodeTaskDurationUs"/>
 </histogram_suffixes>
 
+<histogram_suffixes name="ReferrerAttribution" separator=".">
+  <suffix name="DownloadAttribution" label="Download referrer attribution."/>
+  <suffix name="PhishingInterstitialAttribution"
+      label="Phishing interstitial referrer attribution."/>
+  <suffix name="MalwareInterstitialAttribution"
+      label="Malware interstitial referrer attribution."/>
+  <suffix name="UwsInterstitialAttribution"
+      label="UwS interstitial referrer attribution."/>
+  <affected-histogram name="SB2.ReferrerAttributionResult"/>
+  <affected-histogram name="SB2.ReferrerHasInvalidTabID"/>
+  <affected-histogram name="SB2.ReferrerURLChainSize"/>
+</histogram_suffixes>
+
 <histogram_suffixes name="RemoteProcessWarmStartFast" separator="">
   <suffix name="" label="Normal start."/>
   <suffix name="Fast"