Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: content/browser/web_contents/web_contents_android.h

Issue 2538463002: android: Don't pass ScopedJavaGlobalRef pointers. (Closed)
Patch Set: timeouts are very annoying Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_android.h
diff --git a/content/browser/web_contents/web_contents_android.h b/content/browser/web_contents/web_contents_android.h
index d23f93a2048ec34c39546ed2b9eac098216b7e35..065d9d08e217e6e2f32fb6d745b28156947163d3 100644
--- a/content/browser/web_contents/web_contents_android.h
+++ b/content/browser/web_contents/web_contents_android.h
@@ -190,20 +190,18 @@ class CONTENT_EXPORT WebContentsAndroid
private:
RenderWidgetHostViewAndroid* GetRenderWidgetHostViewAndroid();
- void OnFinishGetContentBitmap(
- base::android::ScopedJavaGlobalRef<jobject>* obj,
- base::android::ScopedJavaGlobalRef<jobject>* callback,
- const SkBitmap& bitmap,
- ReadbackResponse response);
-
- void OnFinishDownloadImage(
- base::android::ScopedJavaGlobalRef<jobject>* obj,
- base::android::ScopedJavaGlobalRef<jobject>* callback,
- int id,
- int http_status_code,
- const GURL& url,
- const std::vector<SkBitmap>& bitmaps,
- const std::vector<gfx::Size>& sizes);
+ void OnFinishGetContentBitmap(const base::android::JavaRef<jobject>& obj,
+ const base::android::JavaRef<jobject>& callback,
+ const SkBitmap& bitmap,
+ ReadbackResponse response);
+
+ void OnFinishDownloadImage(const base::android::JavaRef<jobject>& obj,
+ const base::android::JavaRef<jobject>& callback,
+ int id,
+ int http_status_code,
+ const GURL& url,
+ const std::vector<SkBitmap>& bitmaps,
+ const std::vector<gfx::Size>& sizes);
WebContentsImpl* web_contents_;
NavigationControllerAndroid navigation_controller_;
« no previous file with comments | « content/browser/android/app_web_message_port_service_impl.cc ('k') | content/browser/web_contents/web_contents_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698