Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: content/browser/web_contents/web_contents_android.h

Issue 2538463002: android: Don't pass ScopedJavaGlobalRef pointers. (Closed)
Patch Set: timeouts are very annoying Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_ANDROID_H_ 5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_ANDROID_H_
6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_ANDROID_H_ 6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_ANDROID_H_
7 7
8 #include <jni.h> 8 #include <jni.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 const base::android::JavaParamRef<jobject>& jcallback); 183 const base::android::JavaParamRef<jobject>& jcallback);
184 void DismissTextHandles(JNIEnv* env, 184 void DismissTextHandles(JNIEnv* env,
185 const base::android::JavaParamRef<jobject>& obj); 185 const base::android::JavaParamRef<jobject>& obj);
186 186
187 void SetMediaSession( 187 void SetMediaSession(
188 const base::android::ScopedJavaLocalRef<jobject>& j_media_session); 188 const base::android::ScopedJavaLocalRef<jobject>& j_media_session);
189 189
190 private: 190 private:
191 RenderWidgetHostViewAndroid* GetRenderWidgetHostViewAndroid(); 191 RenderWidgetHostViewAndroid* GetRenderWidgetHostViewAndroid();
192 192
193 void OnFinishGetContentBitmap( 193 void OnFinishGetContentBitmap(const base::android::JavaRef<jobject>& obj,
194 base::android::ScopedJavaGlobalRef<jobject>* obj, 194 const base::android::JavaRef<jobject>& callback,
195 base::android::ScopedJavaGlobalRef<jobject>* callback, 195 const SkBitmap& bitmap,
196 const SkBitmap& bitmap, 196 ReadbackResponse response);
197 ReadbackResponse response);
198 197
199 void OnFinishDownloadImage( 198 void OnFinishDownloadImage(const base::android::JavaRef<jobject>& obj,
200 base::android::ScopedJavaGlobalRef<jobject>* obj, 199 const base::android::JavaRef<jobject>& callback,
201 base::android::ScopedJavaGlobalRef<jobject>* callback, 200 int id,
202 int id, 201 int http_status_code,
203 int http_status_code, 202 const GURL& url,
204 const GURL& url, 203 const std::vector<SkBitmap>& bitmaps,
205 const std::vector<SkBitmap>& bitmaps, 204 const std::vector<gfx::Size>& sizes);
206 const std::vector<gfx::Size>& sizes);
207 205
208 WebContentsImpl* web_contents_; 206 WebContentsImpl* web_contents_;
209 NavigationControllerAndroid navigation_controller_; 207 NavigationControllerAndroid navigation_controller_;
210 base::android::ScopedJavaGlobalRef<jobject> obj_; 208 base::android::ScopedJavaGlobalRef<jobject> obj_;
211 209
212 base::WeakPtrFactory<WebContentsAndroid> weak_factory_; 210 base::WeakPtrFactory<WebContentsAndroid> weak_factory_;
213 211
214 DISALLOW_COPY_AND_ASSIGN(WebContentsAndroid); 212 DISALLOW_COPY_AND_ASSIGN(WebContentsAndroid);
215 }; 213 };
216 214
217 } // namespace content 215 } // namespace content
218 216
219 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_ANDROID_H_ 217 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_ANDROID_H_
OLDNEW
« no previous file with comments | « content/browser/android/app_web_message_port_service_impl.cc ('k') | content/browser/web_contents/web_contents_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698