Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2538373003: [Culprit-Finder] Merge lib/ to libs/. (Closed)

Created:
4 years ago by Sharu Jiang
Modified:
4 years ago
Reviewers:
wrengr, stgao
CC:
chromium-reviews, infra-reviews+infra_chromium.org, Martin Barbella, chanli, lijeffrey
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 : . #

Total comments: 2

Patch Set 2 : Rebase on https://codereview.chromium.org/2557553002/ #

Total comments: 4

Patch Set 3 : Rebase and fix nits. #

Total comments: 6

Patch Set 4 : Fix nits. #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -1721 lines) Patch
M appengine/findit/common/test/chrome_dependency_fetcher_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M appengine/findit/crash/changelist_classifier.py View 1 chunk +2 lines, -1 line 0 comments Download
M appengine/findit/crash/component_classifier.py View 1 chunk +2 lines, -1 line 0 comments Download
M appengine/findit/crash/crash_pipeline.py View 1 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/crash/findit.py View 1 chunk +2 lines, -1 line 0 comments Download
M appengine/findit/crash/scorers/test/scorer_test_suite.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/crash/test/changelist_classifier_test.py View 1 chunk +4 lines, -4 lines 0 comments Download
M appengine/findit/crash/test/component_classifier_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M appengine/findit/crash/test/crash_pipeline_test.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/crash/test/crash_testcase.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/crash/test/findit_for_chromecrash_test.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/crash/test/results_test.py View 1 chunk +3 lines, -3 lines 0 comments Download
M appengine/findit/findit_api.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/gae_libs/caches.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/gae_libs/gitiles/cached_gitiles_repository.py View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M appengine/findit/gae_libs/testcase.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/handlers/calculate_confidence_scores.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/handlers/crash/fracas_dashboard.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/handlers/crash/fracas_result_feedback.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/handlers/crash/test/crash_handler_test.py View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M appengine/findit/handlers/crash/test/fracas_dashboard_test.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/handlers/crash/test/fracas_result_feedback_test.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/handlers/crash/test/triage_fracas_analysis_test.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/handlers/crash/triage_fracas_analysis.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/handlers/flake/check_flake.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/handlers/flake/list_flakes.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/handlers/flake/test/list_flakes_test.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/handlers/list_analyses.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/handlers/test/calculate_confidence_scores_test.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/handlers/test/help_triage_test.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/handlers/test/triage_suspected_cl_test.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/handlers/triage_analysis.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/handlers/triage_suspected_cl.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/handlers/try_job_dashboard.py View 1 chunk +1 line, -1 line 0 comments Download
D appengine/findit/lib/__init__.py View 1 chunk +0 lines, -3 lines 0 comments Download
D appengine/findit/lib/cache_decorator.py View 1 2 3 4 1 chunk +0 lines, -136 lines 0 comments Download
D appengine/findit/lib/gitiles/__init__.py View 1 chunk +0 lines, -3 lines 0 comments Download
D appengine/findit/lib/gitiles/blame.py View 1 chunk +0 lines, -46 lines 0 comments Download
D appengine/findit/lib/gitiles/change_log.py View 1 chunk +0 lines, -110 lines 0 comments Download
D appengine/findit/lib/gitiles/commit_util.py View 1 chunk +0 lines, -71 lines 0 comments Download
D appengine/findit/lib/gitiles/diff.py View 1 chunk +0 lines, -15 lines 0 comments Download
D appengine/findit/lib/gitiles/git_repository.py View 1 chunk +0 lines, -28 lines 0 comments Download
D appengine/findit/lib/gitiles/gitiles_repository.py View 1 1 chunk +0 lines, -224 lines 0 comments Download
D appengine/findit/lib/gitiles/test/__init__.py View 1 chunk +0 lines, -3 lines 0 comments Download
D appengine/findit/lib/gitiles/test/blame_test.py View 1 chunk +0 lines, -43 lines 0 comments Download
D appengine/findit/lib/gitiles/test/change_log_test.py View 1 chunk +0 lines, -48 lines 0 comments Download
D appengine/findit/lib/gitiles/test/commit_util_test.py View 1 chunk +0 lines, -135 lines 0 comments Download
D appengine/findit/lib/gitiles/test/diff_test.py View 1 chunk +0 lines, -16 lines 0 comments Download
D appengine/findit/lib/gitiles/test/gitiles_repository_test.py View 1 1 chunk +0 lines, -450 lines 0 comments Download
D appengine/findit/lib/test/__init__.py View 1 chunk +0 lines, -3 lines 0 comments Download
D appengine/findit/lib/test/cache_decorator_test.py View 1 1 chunk +0 lines, -128 lines 0 comments Download
D appengine/findit/lib/test/time_util_test.py View 1 chunk +0 lines, -64 lines 0 comments Download
D appengine/findit/lib/time_util.py View 1 chunk +0 lines, -98 lines 0 comments Download
A appengine/findit/libs/cache.py View 1 2 3 4 1 chunk +28 lines, -0 lines 0 comments Download
A + appengine/findit/libs/cache_decorator.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + appengine/findit/libs/gitiles/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/findit/libs/gitiles/blame.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/findit/libs/gitiles/change_log.py View 1 chunk +1 line, -1 line 0 comments Download
A + appengine/findit/libs/gitiles/commit_util.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/findit/libs/gitiles/diff.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/findit/libs/gitiles/git_repository.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/findit/libs/gitiles/gitiles_repository.py View 1 1 chunk +8 lines, -8 lines 0 comments Download
A + appengine/findit/libs/gitiles/test/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/findit/libs/gitiles/test/blame_test.py View 1 chunk +2 lines, -1 line 0 comments Download
A + appengine/findit/libs/gitiles/test/change_log_test.py View 1 chunk +2 lines, -1 line 0 comments Download
A + appengine/findit/libs/gitiles/test/commit_util_test.py View 1 chunk +1 line, -1 line 0 comments Download
A + appengine/findit/libs/gitiles/test/diff_test.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
A + appengine/findit/libs/gitiles/test/gitiles_repository_test.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + appengine/findit/libs/test/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/findit/libs/test/cache_decorator_test.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + appengine/findit/libs/test/time_util_test.py View 2 chunks +2 lines, -2 lines 0 comments Download
A + appengine/findit/libs/time_util.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M appengine/findit/model/base_suspected_cl.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/model/base_triaged_model.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/model/suspected_cl_confidence.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/util_scripts/git_checkout/local_git_parsers.py View 1 chunk +7 lines, -7 lines 0 comments Download
M appengine/findit/util_scripts/git_checkout/local_git_repository.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/util_scripts/git_checkout/test/local_git_parsers_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M appengine/findit/util_scripts/git_checkout/test/local_git_repository_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M appengine/findit/util_scripts/local_cache.py View 1 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/util_scripts/script_util.py View 1 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/waterfall/analyze_build_failure_pipeline.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/waterfall/build_failure_analysis.py View 1 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/waterfall/build_failure_analysis_pipelines.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/waterfall/build_util.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/waterfall/flake/initialize_flake_pipeline.py View 1 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/waterfall/flake/recursive_flake_pipeline.py View 1 2 3 2 chunks +5 lines, -3 lines 0 comments Download
M appengine/findit/waterfall/flake/step_mapper.py View 1 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py View 1 3 chunks +3 lines, -3 lines 0 comments Download
M appengine/findit/waterfall/flake/trigger_flake_analyses_pipeline.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/waterfall/identify_culprit_pipeline.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/waterfall/send_notification_for_culprit_pipeline.py View 1 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/waterfall/suspected_cl_util.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/waterfall/test/build_failure_analysis_test.py View 1 chunk +5 lines, -5 lines 0 comments Download
M appengine/findit/waterfall/test/extract_deps_info_pipeline_test.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py View 1 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/waterfall/try_job_util.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 31 (18 generated)
Sharu Jiang
PTAL :)
4 years ago (2016-12-01 23:04:04 UTC) #2
stgao
https://codereview.chromium.org/2538373003/diff/20001/appengine/findit/libs/cache_decorator.py File appengine/findit/libs/cache_decorator.py (right): https://codereview.chromium.org/2538373003/diff/20001/appengine/findit/libs/cache_decorator.py#newcode47 appengine/findit/libs/cache_decorator.py:47: from google.appengine.api import memcache Can you please check all ...
4 years ago (2016-12-02 19:46:16 UTC) #4
Sharu Jiang
https://codereview.chromium.org/2538373003/diff/20001/appengine/findit/libs/cache_decorator.py File appengine/findit/libs/cache_decorator.py (right): https://codereview.chromium.org/2538373003/diff/20001/appengine/findit/libs/cache_decorator.py#newcode47 appengine/findit/libs/cache_decorator.py:47: from google.appengine.api import memcache On 2016/12/02 19:46:16, stgao (slow ...
4 years ago (2016-12-05 23:24:48 UTC) #5
wrengr
lgtm https://codereview.chromium.org/2538373003/diff/40001/appengine/findit/libs/gitiles/test/diff_test.py File appengine/findit/libs/gitiles/test/diff_test.py (right): https://codereview.chromium.org/2538373003/diff/40001/appengine/findit/libs/gitiles/test/diff_test.py#newcode7 appengine/findit/libs/gitiles/test/diff_test.py:7: from libs.gitiles.diff import ChangeType, IsKnownChangeType should be two ...
4 years ago (2016-12-06 22:01:57 UTC) #6
Sharu Jiang
https://codereview.chromium.org/2538373003/diff/40001/appengine/findit/libs/gitiles/test/diff_test.py File appengine/findit/libs/gitiles/test/diff_test.py (right): https://codereview.chromium.org/2538373003/diff/40001/appengine/findit/libs/gitiles/test/diff_test.py#newcode7 appengine/findit/libs/gitiles/test/diff_test.py:7: from libs.gitiles.diff import ChangeType, IsKnownChangeType On 2016/12/06 22:01:57, wrengr ...
4 years ago (2016-12-07 00:13:15 UTC) #7
stgao
lgtm with nits. https://codereview.chromium.org/2538373003/diff/60001/appengine/findit/handlers/crash/test/crash_handler_test.py File appengine/findit/handlers/crash/test/crash_handler_test.py (right): https://codereview.chromium.org/2538373003/diff/60001/appengine/findit/handlers/crash/test/crash_handler_test.py#newcode16 appengine/findit/handlers/crash/test/crash_handler_test.py:16: from libs.gitiles import gitiles_repository import order ...
4 years ago (2016-12-08 00:39:34 UTC) #11
Sharu Jiang
https://codereview.chromium.org/2538373003/diff/60001/appengine/findit/handlers/crash/test/crash_handler_test.py File appengine/findit/handlers/crash/test/crash_handler_test.py (right): https://codereview.chromium.org/2538373003/diff/60001/appengine/findit/handlers/crash/test/crash_handler_test.py#newcode16 appengine/findit/handlers/crash/test/crash_handler_test.py:16: from libs.gitiles import gitiles_repository On 2016/12/08 00:39:33, stgao (slow ...
4 years ago (2016-12-08 01:21:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2538373003/80001
4 years ago (2016-12-08 01:21:28 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: Infra Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/32f4d9c6ba8d7f10)
4 years ago (2016-12-08 01:27:58 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2538373003/100001
4 years ago (2016-12-08 01:33:07 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2538373003/120001
4 years ago (2016-12-08 01:36:56 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2538373003/140001
4 years ago (2016-12-08 01:39:36 UTC) #26
commit-bot: I haz the power
4 years ago (2016-12-08 01:55:08 UTC) #31
Message was sent while issue was closed. 
Committed patchset #7 (id:140001) as
https://chromium.googlesource.com/infra/infra/+/e702a7be924419313208ca0976225...

Powered by Google App Engine
This is Rietveld 408576698