Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Side by Side Diff: appengine/findit/crash/findit.py

Issue 2538373003: [Culprit-Finder] Merge lib/ to libs/. (Closed)
Patch Set: . Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import copy 5 import copy
6 import json 6 import json
7 import logging 7 import logging
8 8
9 from google.appengine.ext import ndb 9 from google.appengine.ext import ndb
10 10
11 from common import appengine_util 11 from common import appengine_util
12 from common import chrome_dependency_fetcher 12 from common import chrome_dependency_fetcher
13 from common import constants 13 from common import constants
14 from crash.crash_report import CrashReport 14 from crash.crash_report import CrashReport
15 from lib import time_util 15 from libs import time_util
16 from model import analysis_status 16 from model import analysis_status
17 from model.crash.crash_config import CrashConfig 17 from model.crash.crash_config import CrashConfig
18 18
19
19 # TODO(http://crbug.com/659346): since most of our unit tests are 20 # TODO(http://crbug.com/659346): since most of our unit tests are
20 # FinditForFracas-specific, wrengr moved them to findit_for_chromecrash_test.py. 21 # FinditForFracas-specific, wrengr moved them to findit_for_chromecrash_test.py.
21 # However, now we're missing coverage for most of this file (due to the 22 # However, now we're missing coverage for most of this file (due to the
22 # buggy way coverage is computed). Need to add a bunch of new unittests 23 # buggy way coverage is computed). Need to add a bunch of new unittests
23 # to get coverage back up. 24 # to get coverage back up.
24 25
25 # TODO: this class depends on ndb stuff, and should therefore move to 26 # TODO: this class depends on ndb stuff, and should therefore move to
26 # cr-culprit-finder/service/predator as part of the big reorganization. 27 # cr-culprit-finder/service/predator as part of the big reorganization.
27 # This class should be renamed to avoid confustion between Findit and Predator. 28 # This class should be renamed to avoid confustion between Findit and Predator.
28 # Think of a good name (e.g.'PredatorApp') for this class. 29 # Think of a good name (e.g.'PredatorApp') for this class.
(...skipping 235 matching lines...) Expand 10 before | Expand all | Expand 10 after
264 stacktrace = self.ParseStacktrace(model) 265 stacktrace = self.ParseStacktrace(model)
265 if stacktrace is None: 266 if stacktrace is None:
266 return None 267 return None
267 268
268 return self._predator.FindCulprit(CrashReport( 269 return self._predator.FindCulprit(CrashReport(
269 crashed_version = model.crashed_version, 270 crashed_version = model.crashed_version,
270 signature = model.signature, 271 signature = model.signature,
271 platform = model.platform, 272 platform = model.platform,
272 stacktrace = stacktrace, 273 stacktrace = stacktrace,
273 regression_range = model.regression_range)) 274 regression_range = model.regression_range))
OLDNEW
« no previous file with comments | « appengine/findit/crash/crash_pipeline.py ('k') | appengine/findit/crash/scorers/test/scorer_test_suite.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698