chrome/browser/resources/settings/controls/settings_toggle_button.js - Issue 2538373002: MD Settings: tweak tap and actionable-ness of <settings-toggle-button>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/controls/settings_toggle_button.js

Issue 2538373002: MD Settings: tweak tap and actionable-ness of <settings-toggle-button> (Closed)

Patch Set: fix tests Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/controls/settings_boolean_control_behavior.js ('K') | « chrome/browser/resources/settings/controls/settings_toggle_button.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/controls/settings_toggle_button.js

diff --git a/chrome/browser/resources/settings/controls/settings_toggle_button.js b/chrome/browser/resources/settings/controls/settings_toggle_button.js

index 95b99a79dc7abcef3ef9745e27a95bafeb8032ac..35a0c02bcd3b4fb9d4936e5d2a4b93ce030fd0ce 100644

--- a/chrome/browser/resources/settings/controls/settings_toggle_button.js

+++ b/chrome/browser/resources/settings/controls/settings_toggle_button.js

@@ -10,4 +10,10 @@ Polymer({

is: 'settings-toggle-button',

behaviors: [SettingsBooleanControlBehavior],

+ /** @private */

+ onLabelWrapperTap_: function() {

+ if (!this.controlDisabled_())

+ this.checked = !this.checked;

+ },

});