MD Settings: tweak tap and actionable-ness of <settings-toggle-button>

chrome/browser/resources/settings/controls/settings_boolean_control_behavior.js

Index: chrome/browser/resources/settings/controls/settings_boolean_control_behavior.js
diff --git a/chrome/browser/resources/settings/controls/settings_boolean_control_behavior.js b/chrome/browser/resources/settings/controls/settings_boolean_control_behavior.js
index 0a2a053d663f33919ecdb85785c4df58ba3add1a..d15e3eb48f89f815c66809f0a8a898369fbe38e8 100644
--- a/chrome/browser/resources/settings/controls/settings_boolean_control_behavior.js
+++ b/chrome/browser/resources/settings/controls/settings_boolean_control_behavior.js
@@ -107,13 +107,11 @@ var SettingsBooleanControlBehaviorImpl = {
   },
 
   /**
-   * @param {boolean} disabled
-   * @param {!chrome.settingsPrivate.PrefObject} pref
    * @return {boolean} Whether the checkbox should be disabled.
    * @private
    */
-  controlDisabled_: function(disabled, pref) {
-    return disabled || this.isPrefPolicyControlled(pref);
+  controlDisabled_: function() {
+    return this.disabled || this.isPrefPolicyControlled(assert(this.pref));

[dschuyler, 2016/12/02 21:20:51]

Is the error within isPrefPolicyControlled unclear when this.pref is not set?
I'm curious about how much the assert is adding/helping.

[Dan Beam, 2016/12/02 23:09:10]

it's required to closure compile.  this.pref should always be set.

[dschuyler, 2016/12/02 23:17:08]

Okay. I wonder if an if() or something could check the var and make closure
happy. It looks like we may be importing a file and making a runtime function
call for the closure compiler.

[Dan Beam, 2016/12/02 23:21:28]

we are doing both of those things, BUT:

a) assert.html will be de-duped, it's used many many many times throughout our
page but every subsequent <link rel=import> is ignored

b) there are many places that run assert() and it's a good thing that we're
checking that this.pref is set.  because if not, there's problems.

   },
 };