[Mac] Active state for the security decoration

[Mac] Active state for the security omnibox decoration

Security state decoration is set to active when the WebsiteSettingsBubble is opened

BUG=588377
Committed: https://crrev.com/0467760e3dd87fff6bd53d59cb1181aab4ace953
Cr-Commit-Position: refs/heads/master@{#437926}

[spqchan, 2016-12-01 23:20:52]

Description was changed from

==========
[Mac] Active state for the web setting bubble

BUG=
==========

to

==========
[Mac] Active state for the web setting bubble

BUG=588377
==========

[spqchan, 2016-12-01 23:21:41]

Description was changed from

==========
[Mac] Active state for the web setting bubble

BUG=588377
==========

to

==========
[Mac] Active state for the security state and EV cert icon



BUG=588377
==========

[spqchan, 2016-12-01 23:38:30]

Description was changed from

==========
[Mac] Active state for the security state and EV cert icon



BUG=588377
==========

to

==========
[Mac] Active state for the draggable and security omnibox decorations

- Draggable decorations in the omnibox are now set to active when they begin
 dragging and nonactive after the dragging session has ended
- Security state and EV cert decorations are set to active when the
 WebSettingsBubble is opened


BUG=588377
==========

[spqchan, 2016-12-01 23:38:30]

spqchan@chromium.org changed reviewers:
+ shrike@chromium.org

[spqchan, 2016-12-01 23:40:07]

Description was changed from

==========
[Mac] Active state for the draggable and security omnibox decorations

- Draggable decorations in the omnibox are now set to active when they begin
 dragging and nonactive after the dragging session has ended
- Security state and EV cert decorations are set to active when the
 WebSettingsBubble is opened


BUG=588377
==========

to

==========
[Mac] Active state for the draggable and security omnibox decorations

- Draggable decorations in the omnibox are now set to active when they begin
 dragging and nonactive after the dragging session has ended
- Security state and EV cert decorations are set to active when the
 WebsiteSettingsBubble is opened


BUG=588377
==========

[spqchan, 2016-12-01 23:41:08]

Description was changed from

==========
[Mac] Active state for the draggable and security omnibox decorations

- Draggable decorations in the omnibox are now set to active when they begin
 dragging and nonactive after the dragging session has ended
- Security state and EV cert decorations are set to active when the
 WebsiteSettingsBubble is opened


BUG=588377
==========

to

==========
[Mac] Active state for the draggable and security omnibox decorations

- Draggable decorations in the omnibox are now set to active when they begin
 dragging and nonactive after the dragging session has ended
- Security state decoration is set to active when the WebsiteSettingsBubble is
opened


BUG=588377
==========

[spqchan, 2016-12-01 23:47:56]

The CQ bit was checked by spqchan@chromium.org to run a CQ dry run

[spqchan, 2016-12-01 23:48:04]

PTAL

[commit-bot: I haz the power, 2016-12-01 23:48:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 00:05:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 00:05:19]

Dry run: This issue passed the CQ dry run.

[shrike, 2016-12-03 01:37:02]

What is an example of a draggable decoration?

[spqchan, 2016-12-05 18:18:19]

On 2016/12/03 01:37:02, shrike wrote:
> What is an example of a draggable decoration?

The security decoration in http://www.target.com/

[shrike, 2016-12-05 20:09:58]

On 2016/12/05 18:18:19, spqchan wrote:
> On 2016/12/03 01:37:02, shrike wrote:
> > What is an example of a draggable decoration?
> 
> The security decoration in http://www.target.com/

Can you provide a little more info (I'm not sure what you're referring to)?
Maybe a few numbered steps?

[spqchan, 2016-12-05 22:22:33]

On 2016/12/05 20:09:58, shrike wrote:
> On 2016/12/05 18:18:19, spqchan wrote:
> > On 2016/12/03 01:37:02, shrike wrote:
> > > What is an example of a draggable decoration?
> > 
> > The security decoration in http://www.target.com/
> 
> Can you provide a little more info (I'm not sure what you're referring to)?
> Maybe a few numbered steps?

1) Go to http://www.target.com
2) Click and drag the (i) icon in the omnibox
3) The icon should appear as "active" until you release the mouse

[shrike, 2016-12-06 01:31:30]

On 2016/12/05 22:22:33, spqchan wrote:
> 1) Go to http://www.target.com
> 2) Click and drag the (i) icon in the omnibox
> 3) The icon should appear as "active" until you release the mouse

OK. How does that relate to not being able to drag a URL from there? That's what
I get the moment I start dragging. Can you disable that in this cl as well?

I don't think the icon should remain active if you drag outside of the icon's
border. Normally with a button if you click and drag outside it returns to its
normal state, and if you release at that point the button's action does not
fire. You can click down and drag outside and back in repeatedly, and as long as
you're holding down the mouse the button will depress when you're inside its
bounds and return to its normal state when you're outside.

[spqchan, 2016-12-06 01:41:14]

On 2016/12/06 01:31:30, shrike wrote:
> On 2016/12/05 22:22:33, spqchan wrote:
> > 1) Go to http://www.target.com
> > 2) Click and drag the (i) icon in the omnibox
> > 3) The icon should appear as "active" until you release the mouse
> 
> OK. How does that relate to not being able to drag a URL from there? That's
what
> I get the moment I start dragging. Can you disable that in this cl as well?
> 

I don't know what you mean by "not being able to drag a URL from there".
Anyway, sure. I'll disable dragging. I'll do it in a separate CL though because
since this is the only decoration that uses dragging, I may as well remove all
of the dragging code in the omnibox decorations. Otherwise, we'll end up with
even more dead code.

> I don't think the icon should remain active if you drag outside of the icon's
> border. Normally with a button if you click and drag outside it returns to its
> normal state, and if you release at that point the button's action does not
> fire. You can click down and drag outside and back in repeatedly, and as long
as
> you're holding down the mouse the button will depress when you're inside its
> bounds and return to its normal state when you're outside.

I don't agree with that since it'll be confusing if we do that. But none of this
will matter since we're remove dragging.
I'll remove the dragging changes in this CL and will let you know once it's
updated

[spqchan, 2016-12-06 01:50:55]

Description was changed from

==========
[Mac] Active state for the draggable and security omnibox decorations

- Draggable decorations in the omnibox are now set to active when they begin
 dragging and nonactive after the dragging session has ended
- Security state decoration is set to active when the WebsiteSettingsBubble is
opened


BUG=588377
==========

to

==========
[Mac] Active state for the security omnibox decoration

Security state decoration is set to active when the WebsiteSettingsBubble is
opened


BUG=588377
==========

[spqchan, 2016-12-06 01:51:14]

The CQ bit was checked by spqchan@chromium.org to run a CQ dry run

[spqchan, 2016-12-06 01:51:22]

On 2016/12/06 01:41:14, spqchan wrote:
> On 2016/12/06 01:31:30, shrike wrote:
> > On 2016/12/05 22:22:33, spqchan wrote:
> > > 1) Go to http://www.target.com
> > > 2) Click and drag the (i) icon in the omnibox
> > > 3) The icon should appear as "active" until you release the mouse
> > 
> > OK. How does that relate to not being able to drag a URL from there? That's
> what
> > I get the moment I start dragging. Can you disable that in this cl as well?
> > 
> 
> I don't know what you mean by "not being able to drag a URL from there".
> Anyway, sure. I'll disable dragging. I'll do it in a separate CL though
because
> since this is the only decoration that uses dragging, I may as well remove all
> of the dragging code in the omnibox decorations. Otherwise, we'll end up with
> even more dead code.
> 
> > I don't think the icon should remain active if you drag outside of the
icon's
> > border. Normally with a button if you click and drag outside it returns to
its
> > normal state, and if you release at that point the button's action does not
> > fire. You can click down and drag outside and back in repeatedly, and as
long
> as
> > you're holding down the mouse the button will depress when you're inside its
> > bounds and return to its normal state when you're outside.
> 
> I don't agree with that since it'll be confusing if we do that. But none of
this
> will matter since we're remove dragging.
> I'll remove the dragging changes in this CL and will let you know once it's
> updated

Removed it

[commit-bot: I haz the power, 2016-12-06 01:52:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 02:18:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 02:18:16]

Dry run: This issue passed the CQ dry run.

[spqchan, 2016-12-07 18:09:20]

On 2016/12/06 01:51:22, spqchan wrote:
> On 2016/12/06 01:41:14, spqchan wrote:
> > On 2016/12/06 01:31:30, shrike wrote:
> > > On 2016/12/05 22:22:33, spqchan wrote:
> > > > 1) Go to http://www.target.com
> > > > 2) Click and drag the (i) icon in the omnibox
> > > > 3) The icon should appear as "active" until you release the mouse
> > > 
> > > OK. How does that relate to not being able to drag a URL from there?
That's
> > what
> > > I get the moment I start dragging. Can you disable that in this cl as
well?
> > > 
> > 
> > I don't know what you mean by "not being able to drag a URL from there".
> > Anyway, sure. I'll disable dragging. I'll do it in a separate CL though
> because
> > since this is the only decoration that uses dragging, I may as well remove
all
> > of the dragging code in the omnibox decorations. Otherwise, we'll end up
with
> > even more dead code.
> > 
> > > I don't think the icon should remain active if you drag outside of the
> icon's
> > > border. Normally with a button if you click and drag outside it returns to
> its
> > > normal state, and if you release at that point the button's action does
not
> > > fire. You can click down and drag outside and back in repeatedly, and as
> long
> > as
> > > you're holding down the mouse the button will depress when you're inside
its
> > > bounds and return to its normal state when you're outside.
> > 
> > I don't agree with that since it'll be confusing if we do that. But none of
> this
> > will matter since we're remove dragging.
> > I'll remove the dragging changes in this CL and will let you know once it's
> > updated
> 
> Removed it

ping

[shrike, 2016-12-07 18:44:49]

On 2016/12/07 18:09:20, spqchan wrote:
> On 2016/12/06 01:51:22, spqchan wrote:
> > On 2016/12/06 01:41:14, spqchan wrote:
> > > On 2016/12/06 01:31:30, shrike wrote:
> > > > On 2016/12/05 22:22:33, spqchan wrote:
> > > > > 1) Go to http://www.target.com
> > > > > 2) Click and drag the (i) icon in the omnibox
> > > > > 3) The icon should appear as "active" until you release the mouse
> > > > 
> > > > OK. How does that relate to not being able to drag a URL from there?
> That's
> > > what
> > > > I get the moment I start dragging. Can you disable that in this cl as
> well?
> > > > 
> > > 
> > > I don't know what you mean by "not being able to drag a URL from there".
> > > Anyway, sure. I'll disable dragging. I'll do it in a separate CL though
> > because
> > > since this is the only decoration that uses dragging, I may as well remove
> all
> > > of the dragging code in the omnibox decorations. Otherwise, we'll end up
> with
> > > even more dead code.
> > > 
> > > > I don't think the icon should remain active if you drag outside of the
> > icon's
> > > > border. Normally with a button if you click and drag outside it returns
to
> > its
> > > > normal state, and if you release at that point the button's action does
> not
> > > > fire. You can click down and drag outside and back in repeatedly, and as
> > long
> > > as
> > > > you're holding down the mouse the button will depress when you're inside
> its
> > > > bounds and return to its normal state when you're outside.
> > > 
> > > I don't agree with that since it'll be confusing if we do that. But none
of
> > this
> > > will matter since we're remove dragging.
> > > I'll remove the dragging changes in this CL and will let you know once
it's
> > > updated
> > 
> > Removed it
> 
> ping

I'm not exactly sure how to confirm this change. When I go to android.com, say,
and click the Secure security decoration it seems to be active even without this
change?

Re: dragging there are two issues. I think I may not have been clear - we should
have a quick VC to discuss.

[spqchan, 2016-12-07 19:55:13]

On 2016/12/07 18:44:49, shrike wrote:
> On 2016/12/07 18:09:20, spqchan wrote:
> > On 2016/12/06 01:51:22, spqchan wrote:
> > > On 2016/12/06 01:41:14, spqchan wrote:
> > > > On 2016/12/06 01:31:30, shrike wrote:
> > > > > On 2016/12/05 22:22:33, spqchan wrote:
> > > > > > 1) Go to http://www.target.com
> > > > > > 2) Click and drag the (i) icon in the omnibox
> > > > > > 3) The icon should appear as "active" until you release the mouse
> > > > > 
> > > > > OK. How does that relate to not being able to drag a URL from there?
> > That's
> > > > what
> > > > > I get the moment I start dragging. Can you disable that in this cl as
> > well?
> > > > > 
> > > > 
> > > > I don't know what you mean by "not being able to drag a URL from there".
> > > > Anyway, sure. I'll disable dragging. I'll do it in a separate CL though
> > > because
> > > > since this is the only decoration that uses dragging, I may as well
remove
> > all
> > > > of the dragging code in the omnibox decorations. Otherwise, we'll end up
> > with
> > > > even more dead code.
> > > > 
> > > > > I don't think the icon should remain active if you drag outside of the
> > > icon's
> > > > > border. Normally with a button if you click and drag outside it
returns
> to
> > > its
> > > > > normal state, and if you release at that point the button's action
does
> > not
> > > > > fire. You can click down and drag outside and back in repeatedly, and
as
> > > long
> > > > as
> > > > > you're holding down the mouse the button will depress when you're
inside
> > its
> > > > > bounds and return to its normal state when you're outside.
> > > > 
> > > > I don't agree with that since it'll be confusing if we do that. But none
> of
> > > this
> > > > will matter since we're remove dragging.
> > > > I'll remove the dragging changes in this CL and will let you know once
> it's
> > > > updated
> > > 
> > > Removed it
> > 
> > ping
> 
> I'm not exactly sure how to confirm this change. When I go to
http://android.com, say,
> and click the Secure security decoration it seems to be active even without
this
> change?
> 
> Re: dragging there are two issues. I think I may not have been clear - we
should
> have a quick VC to discuss.

Oh right, sorry, I forgot to mention that the current behavior is technically
correct because of how the mouse events are intercepted for the security state
decoration.
I'm adding this in anyway though because we don't want to rely on that (since if
that changes then this will break, it's better to rely on the dialog).
 
Anyway, what is up with dragging? Are we getting rid of it or not? If we're
getting rid of it, then there shouldn't be any dragging issues with the icon.
Feel free to set up a GVC meeting for discussion

[spqchan, 2016-12-08 04:06:39]

On 2016/12/07 19:55:13, spqchan wrote:
> On 2016/12/07 18:44:49, shrike wrote:
> > On 2016/12/07 18:09:20, spqchan wrote:
> > > On 2016/12/06 01:51:22, spqchan wrote:
> > > > On 2016/12/06 01:41:14, spqchan wrote:
> > > > > On 2016/12/06 01:31:30, shrike wrote:
> > > > > > On 2016/12/05 22:22:33, spqchan wrote:
> > > > > > > 1) Go to http://www.target.com
> > > > > > > 2) Click and drag the (i) icon in the omnibox
> > > > > > > 3) The icon should appear as "active" until you release the mouse
> > > > > > 
> > > > > > OK. How does that relate to not being able to drag a URL from there?
> > > That's
> > > > > what
> > > > > > I get the moment I start dragging. Can you disable that in this cl
as
> > > well?
> > > > > > 
> > > > > 
> > > > > I don't know what you mean by "not being able to drag a URL from
there".
> > > > > Anyway, sure. I'll disable dragging. I'll do it in a separate CL
though
> > > > because
> > > > > since this is the only decoration that uses dragging, I may as well
> remove
> > > all
> > > > > of the dragging code in the omnibox decorations. Otherwise, we'll end
up
> > > with
> > > > > even more dead code.
> > > > > 
> > > > > > I don't think the icon should remain active if you drag outside of
the
> > > > icon's
> > > > > > border. Normally with a button if you click and drag outside it
> returns
> > to
> > > > its
> > > > > > normal state, and if you release at that point the button's action
> does
> > > not
> > > > > > fire. You can click down and drag outside and back in repeatedly,
and
> as
> > > > long
> > > > > as
> > > > > > you're holding down the mouse the button will depress when you're
> inside
> > > its
> > > > > > bounds and return to its normal state when you're outside.
> > > > > 
> > > > > I don't agree with that since it'll be confusing if we do that. But
none
> > of
> > > > this
> > > > > will matter since we're remove dragging.
> > > > > I'll remove the dragging changes in this CL and will let you know once
> > it's
> > > > > updated
> > > > 
> > > > Removed it
> > > 
> > > ping
> > 
> > I'm not exactly sure how to confirm this change. When I go to
> http://android.com, say,
> > and click the Secure security decoration it seems to be active even without
> this
> > change?
> > 
> > Re: dragging there are two issues. I think I may not have been clear - we
> should
> > have a quick VC to discuss.
> 
> Oh right, sorry, I forgot to mention that the current behavior is technically
> correct because of how the mouse events are intercepted for the security state
> decoration.
> I'm adding this in anyway though because we don't want to rely on that (since
if
> that changes then this will break, it's better to rely on the dialog).
>  
> Anyway, what is up with dragging? Are we getting rid of it or not? If we're
> getting rid of it, then there shouldn't be any dragging issues with the icon.
> Feel free to set up a GVC meeting for discussion

Something you can do to test this out:

1) Open two Chrome windows 
2) Click the security indicator on one of the windows
3) Click on the second 

Without my change, the security indicator will remain "active" even though the
bubble is gone
However with my change that will be fixed

[shrike, 2016-12-10 01:43:03]

lgtm

[spqchan, 2016-12-12 18:21:30]

spqchan@chromium.org changed reviewers:
+ rsesek@chromium.org

[spqchan, 2016-12-12 18:21:31]

+avi for ownership

[spqchan, 2016-12-12 18:21:43]

spqchan@chromium.org changed reviewers:
+ avi@chromium.org
- rsesek@chromium.org

[spqchan, 2016-12-12 18:22:01]

+avi for ownership

[Avi (use Gerrit), 2016-12-12 18:24:55]

lgtm

stamp

[spqchan, 2016-12-12 18:28:05]

On 2016/12/12 18:24:55, Avi wrote:
> lgtm
> 
> stamp

thanks!

[spqchan, 2016-12-12 18:28:11]

The CQ bit was checked by spqchan@chromium.org

[commit-bot: I haz the power, 2016-12-12 18:28:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 22:10:40]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481567291634130,
"parent_rev": "5c634996fe9015240ce3f66bb184e5ab4ec4816e", "commit_rev":
"ef54fc28e30a1a7220d5e9b077290eafbe69e308"}

[commit-bot: I haz the power, 2016-12-12 22:11:07]

Description was changed from

==========
[Mac] Active state for the security omnibox decoration

Security state decoration is set to active when the WebsiteSettingsBubble is
opened


BUG=588377
==========

to

==========
[Mac] Active state for the security omnibox decoration

Security state decoration is set to active when the WebsiteSettingsBubble is
opened


BUG=588377

Review-Url: https://codereview.chromium.org/2538323003
==========

[commit-bot: I haz the power, 2016-12-12 22:11:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-12 22:13:07]

Description was changed from

==========
[Mac] Active state for the security omnibox decoration

Security state decoration is set to active when the WebsiteSettingsBubble is
opened


BUG=588377

Review-Url: https://codereview.chromium.org/2538323003
==========

to

==========
[Mac] Active state for the security omnibox decoration

Security state decoration is set to active when the WebsiteSettingsBubble is
opened

BUG=588377

Committed: https://crrev.com/0467760e3dd87fff6bd53d59cb1181aab4ace953
Cr-Commit-Position: refs/heads/master@{#437926}
==========

[commit-bot: I haz the power, 2016-12-12 22:13:08]

Patchset 3 (id:??) landed as
https://crrev.com/0467760e3dd87fff6bd53d59cb1181aab4ace953
Cr-Commit-Position: refs/heads/master@{#437926}