Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2538233004: DevTools: accessibility fix for tab from prompt (Closed)

Created:
4 years ago by luoe
Modified:
4 years ago
Reviewers:
einbinder, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: accessibility fix for tab from prompt TextPrompt used to always consume 'Tab' keys, preventing the use of tab to navigate from a prompt to checkboxes. This CL makes the handler consume only if autocomplete is handled. BUG=668161

Patch Set 1 #

Patch Set 2 : DevTools: accessibility fix for tab from prompt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
luoe
Please take a look.
4 years ago (2016-12-02 21:41:15 UTC) #3
lushnikov
does this change preserve the tab behavior in Styles sidebar pane?
4 years ago (2016-12-03 01:23:39 UTC) #4
luoe
On 2016/12/03 01:23:39, lushnikov wrote: > does this change preserve the tab behavior in Styles ...
4 years ago (2016-12-03 01:57:39 UTC) #5
dgozman
> One effect of this CL is that pressing tab in a FilteredListWidget's prompt may ...
4 years ago (2016-12-04 18:59:55 UTC) #6
luoe
4 years ago (2016-12-05 18:53:20 UTC) #7
I'm not sure what I was thinking, I don't intend to introduce this regression. 
Focus will move into the browser URL bar and even the target page.  Let me
revise this CL first.

Powered by Google App Engine
This is Rietveld 408576698