Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 253823002: Compute and use BiDi information in SVGTextMetricsBuilder (Closed)

Created:
6 years, 7 months ago by fs
Modified:
6 years, 7 months ago
Reviewers:
pdr., eae, eseidel
CC:
blink-reviews, rwlbuis, chrishtr, krit, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, ojan, Stephen Chennney, rune+blink, leviw_travelin_and_unemployed, behdad
Visibility:
Public.

Description

Compute and use BiDi information in SVGTextMetricsBuilder This extends upon https://codereview.chromium.org/104813005, by computing (and plumbing) directionality information for SVG text elements. The method used is similar to that used by RenderText::computePreferredLogicalWidths although simplified somewhat. BUG=366939 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172799

Patch Set 1 #

Patch Set 2 : Testcase. #

Patch Set 3 : TestExpectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
A LayoutTests/svg/text/bidi-getcomputedtextlength.html View 1 1 chunk +32 lines, -0 lines 0 comments Download
A LayoutTests/svg/text/bidi-getcomputedtextlength-expected.txt View 1 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/SVGTextMetrics.h View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/SVGTextMetrics.cpp View 3 chunks +13 lines, -1 line 0 comments Download
M Source/core/rendering/svg/SVGTextMetricsBuilder.cpp View 7 chunks +51 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
eseidel
6 years, 7 months ago (2014-04-28 15:33:02 UTC) #1
eae
LGTM I shame we can't reuse more of this logic.
6 years, 7 months ago (2014-04-28 15:37:27 UTC) #2
fs
On 2014/04/28 15:37:27, eae wrote: > LGTM > > I shame we can't reuse more ...
6 years, 7 months ago (2014-04-28 15:55:23 UTC) #3
fs
pdr, if you have any comments, feel free to voice them, otherwise I think this ...
6 years, 7 months ago (2014-04-28 16:28:59 UTC) #4
pdr.
On 2014/04/28 16:28:59, fs wrote: > pdr, if you have any comments, feel free to ...
6 years, 7 months ago (2014-04-28 19:11:27 UTC) #5
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 7 months ago (2014-04-28 19:11:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/253823002/40001
6 years, 7 months ago (2014-04-28 19:11:50 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 20:23:58 UTC) #8
Message was sent while issue was closed.
Change committed as 172799

Powered by Google App Engine
This is Rietveld 408576698