Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Side by Side Diff: Source/core/rendering/svg/SVGTextMetrics.h

Issue 253823002: Compute and use BiDi information in SVGTextMetricsBuilder (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: TestExpectations. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) Research In Motion Limited 2010-2012. All rights reserved. 2 * Copyright (C) Research In Motion Limited 2010-2012. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
12 * Library General Public License for more details. 12 * Library General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU Library General Public License 14 * You should have received a copy of the GNU Library General Public License
15 * along with this library; see the file COPYING.LIB. If not, write to 15 * along with this library; see the file COPYING.LIB. If not, write to
16 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 16 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
17 * Boston, MA 02110-1301, USA. 17 * Boston, MA 02110-1301, USA.
18 */ 18 */
19 19
20 #ifndef SVGTextMetrics_h 20 #ifndef SVGTextMetrics_h
21 #define SVGTextMetrics_h 21 #define SVGTextMetrics_h
22 22
23 #include "platform/fonts/Glyph.h" 23 #include "platform/fonts/Glyph.h"
24 #include "platform/text/TextDirection.h"
24 #include "wtf/text/WTFString.h" 25 #include "wtf/text/WTFString.h"
25 26
26 namespace WebCore { 27 namespace WebCore {
27 28
28 class RenderSVGInlineText; 29 class RenderSVGInlineText;
29 class SVGTextLayoutAttributes; 30 class SVGTextLayoutAttributes;
30 class TextRun; 31 class TextRun;
31 32
32 class SVGTextMetrics { 33 class SVGTextMetrics {
33 public: 34 public:
34 enum MetricsType { 35 enum MetricsType {
35 SkippedSpaceMetrics 36 SkippedSpaceMetrics
36 }; 37 };
37 38
38 SVGTextMetrics(); 39 SVGTextMetrics();
39 SVGTextMetrics(MetricsType); 40 SVGTextMetrics(MetricsType);
40 SVGTextMetrics(RenderSVGInlineText*, unsigned position, unsigned length, flo at width, Glyph glyphNameGlyphId); 41 SVGTextMetrics(RenderSVGInlineText*, unsigned position, unsigned length, flo at width, Glyph glyphNameGlyphId);
41 42
43 // FIXME: Migrate away from these to the two below.
42 static SVGTextMetrics measureCharacterRange(RenderSVGInlineText*, unsigned p osition, unsigned length); 44 static SVGTextMetrics measureCharacterRange(RenderSVGInlineText*, unsigned p osition, unsigned length);
43 static TextRun constructTextRun(RenderSVGInlineText*, unsigned position, uns igned length); 45 static TextRun constructTextRun(RenderSVGInlineText*, unsigned position, uns igned length);
44 46
47 static SVGTextMetrics measureCharacterRange(RenderSVGInlineText*, unsigned p osition, unsigned length, TextDirection);
48 static TextRun constructTextRun(RenderSVGInlineText*, unsigned position, uns igned length, TextDirection);
49
45 bool isEmpty() const { return !m_width && !m_height && m_length <= 1; } 50 bool isEmpty() const { return !m_width && !m_height && m_length <= 1; }
46 51
47 float width() const { return m_width; } 52 float width() const { return m_width; }
48 void setWidth(float width) { m_width = width; } 53 void setWidth(float width) { m_width = width; }
49 54
50 float height() const { return m_height; } 55 float height() const { return m_height; }
51 unsigned length() const { return m_length; } 56 unsigned length() const { return m_length; }
52 57
53 // Only useful when measuring individual characters, to lookup ligatures. 58 // Only useful when measuring individual characters, to lookup ligatures.
54 Glyph glyph() const { return m_glyph; } 59 Glyph glyph() const { return m_glyph; }
55 60
56 private: 61 private:
57 SVGTextMetrics(RenderSVGInlineText*, const TextRun&); 62 SVGTextMetrics(RenderSVGInlineText*, const TextRun&);
58 63
59 float m_width; 64 float m_width;
60 float m_height; 65 float m_height;
61 unsigned m_length; 66 unsigned m_length;
62 Glyph m_glyph; 67 Glyph m_glyph;
63 }; 68 };
64 69
65 } // namespace WebCore 70 } // namespace WebCore
66 71
67 #endif 72 #endif
OLDNEW
« no previous file with comments | « LayoutTests/svg/text/bidi-getcomputedtextlength-expected.txt ('k') | Source/core/rendering/svg/SVGTextMetrics.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698