Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(42)

Issue 2538183002: remoting: Cleanup class/struct fwd declarations (Closed)

Created:
2 years, 9 months ago by jbriance
Modified:
2 years, 9 months ago
Reviewers:
Sergey Ulanov, Lambros
CC:
chromium-reviews, posciak+watch_chromium.org, scheib+watch_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

remoting: Cleanup class/struct fwd declarations Remove useless class and struct forward declarations, and add missing ones in remoting header files. BUG=662195 Committed: https://crrev.com/e9b2ece8b371f59f37e42159da4c00313d67407f Cr-Commit-Position: refs/heads/master@{#435574}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -123 lines) Patch
M remoting/client/chromoting_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/client/gl_desktop.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/client/ios/bridge/client_instance.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/client/jni/chromoting_jni_instance.h View 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/client/jni/jni_gl_display_handler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/client/plugin/pepper_input_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/client/plugin/pepper_mouse_locker.h View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/client/plugin/pepper_video_renderer.h View 2 chunks +0 lines, -8 lines 0 comments Download
M remoting/client/plugin/pepper_video_renderer_2d.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/basic_desktop_environment.h View 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/host/client_session.h View 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/host/desktop_capturer_proxy.h View 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/host/desktop_environment.h View 2 chunks +0 lines, -8 lines 0 comments Download
M remoting/host/desktop_process.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/host_mock_objects.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/host_power_save_blocker.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/host_status_observer.h View 1 chunk +0 lines, -5 lines 0 comments Download
M remoting/host/it2me/it2me_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/native_messaging/pipe_messaging_channel.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/setup/daemon_controller_delegate_win.h View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/host/setup/gaia_oauth_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/host/setup/me2me_native_messaging_host.h View 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/host/token_validator_factory_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/host/win/worker_process_launcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/audio_writer.h View 1 chunk +0 lines, -5 lines 0 comments Download
M remoting/protocol/client_control_dispatcher.h View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/protocol/client_video_stats_dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/connection_to_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/protocol/connection_to_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/host_control_dispatcher.h View 1 chunk +0 lines, -5 lines 0 comments Download
M remoting/protocol/host_event_dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/host_stub.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/ice_connection_to_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/protocol/ice_transport_channel.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/jingle_session_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/protocol_mock_objects.h View 1 chunk +3 lines, -0 lines 0 comments Download
M remoting/protocol/session.h View 1 chunk +0 lines, -7 lines 0 comments Download
M remoting/protocol/token_validator.h View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/protocol/transport.h View 1 chunk +0 lines, -7 lines 0 comments Download
M remoting/protocol/webrtc_audio_module.h View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/protocol/webrtc_audio_source_adapter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/protocol/webrtc_frame_scheduler.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/webrtc_video_renderer_adapter.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/webrtc_video_stream.h View 2 chunks +0 lines, -3 lines 0 comments Download
M remoting/test/app_remoting_connection_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/test/app_remoting_report_issue_request.h View 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/test/chromoting_test_fixture.h View 1 chunk +0 lines, -6 lines 0 comments Download
M remoting/test/connection_time_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/test/host_list_fetcher.h View 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/test/remote_host_info_fetcher.h View 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/test/test_chromoting_client.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
jbriance
2 years, 9 months ago (2016-11-30 17:27:01 UTC) #2
Sergey Ulanov
LGTM Thank you for the cleanup!
2 years, 9 months ago (2016-12-01 01:13:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2538183002/1
2 years, 9 months ago (2016-12-01 07:02:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
2 years, 9 months ago (2016-12-01 07:30:22 UTC) #7
commit-bot: I haz the power
2 years, 9 months ago (2016-12-01 07:31:44 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e9b2ece8b371f59f37e42159da4c00313d67407f
Cr-Commit-Position: refs/heads/master@{#435574}

Powered by Google App Engine
This is Rietveld 408576698