Issue 2538053003: Implement vrdisplayactivate for GVR DON.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2538053003: Implement vrdisplayactivate for GVR DON. (Closed)

Created:
4 years ago by bshe

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

Implement vrdisplayactivate for GVR DON. This allows webVR pages to auto-present when the DON flow is triggered by putting the phone in the headset, rather than by the page requesting WebVR. BUG=641401 Review-Url: https://codereview.chromium.org/2502363004 Cr-Commit-Position: refs/heads/master@{#433213} (cherry picked from commit c34e2fa914fb0f72599f632c3168f9ec3884441f) Committed: https://chromium.googlesource.com/chromium/src/+/3ce07cc452c18c78e717feaadb20b7a1b8359ca5

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -16 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java	View	5 chunks	+13 lines, -5 lines	0 comments	Download
M	chrome/browser/android/vr_shell/vr_shell_delegate.h	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/android/vr_shell/vr_shell_delegate.cc	View	2 chunks	+11 lines, -4 lines	0 comments	Download
M	device/vr/android/gvr/gvr_delegate.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	device/vr/android/gvr/gvr_device_provider.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	device/vr/android/gvr/gvr_device_provider.cc	View	4 chunks	+9 lines, -3 lines	0 comments	Download

Total messages: 2 (1 generated)

bshe

4 years ago (2016-11-30 17:44:52 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3ce07cc452c18c78e717feaadb20b7a1b8359ca5.