Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2502363004: Implement vrdisplayactivate for GVR DON. (Closed)

Created:
4 years, 1 month ago by mthiesse
Modified:
4 years, 1 month ago
Reviewers:
bajones, bshe
CC:
chromium-reviews, feature-vr-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement vrdisplayactivate for GVR DON. This allows webVR pages to auto-present when the DON flow is triggered by putting the phone in the headset, rather than by the page requesting WebVR. BUG=641401 Committed: https://crrev.com/c34e2fa914fb0f72599f632c3168f9ec3884441f Cr-Commit-Position: refs/heads/master@{#433213}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -16 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 5 chunks +13 lines, -5 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_delegate.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_delegate.cc View 2 chunks +11 lines, -4 lines 0 comments Download
M device/vr/android/gvr/gvr_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M device/vr/android/gvr/gvr_device_provider.h View 1 chunk +1 line, -0 lines 0 comments Download
M device/vr/android/gvr/gvr_device_provider.cc View 4 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
mthiesse
PTAL
4 years, 1 month ago (2016-11-17 21:32:11 UTC) #2
bajones
On 2016/11/17 21:32:11, mthiesse wrote: > PTAL LGTM!
4 years, 1 month ago (2016-11-17 21:39:26 UTC) #4
bshe
On 2016/11/17 21:39:26, bajones wrote: > On 2016/11/17 21:32:11, mthiesse wrote: > > PTAL > ...
4 years, 1 month ago (2016-11-17 21:41:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502363004/20001
4 years, 1 month ago (2016-11-18 15:31:47 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-18 16:13:40 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 16:16:12 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c34e2fa914fb0f72599f632c3168f9ec3884441f
Cr-Commit-Position: refs/heads/master@{#433213}

Powered by Google App Engine
This is Rietveld 408576698