Replace ValueSetOutputFormatter with HistogramSetJsonOutputFormatter.

Replace ValueSetOutputFormatter with HistogramSetJsonOutputFormatter.

Currently, run_benchmark --output=valueset dumps TBMv2 Histograms to JSON, but
it does not convert TBMv1 Values to Histograms, nor does it read existing
results, nor does it support uploading. Also the name is wrong.

This CL renames ValueSetOutputFormatter to HistogramSetJsonOutputFormatter, and
re-conceptualizes it as a subclass of Html2OutputFormatter in order to support
converting TBMv1 Values to Histograms and uploading.
The new HistogramSetJsonOutputFormatter now also reads existing results.

http://go/histogram-set-json-format
http://go/histogram-pipeline

BUG=catapult:#2717

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/77ad967bf0a4a9358d57fe42a6fd2a83a422ff49

[benjhayden, 2016-12-02 19:42:31]

Description was changed from

==========
Replace ValueSetOutputFormatter with HistogramSetJsonOutputFormatter.

Currently, run_benchmark --output=valueset dumps TBMv2 Histograms to JSON, but
it does not convert TBMv1 Values to Histograms, nor does it read existing
results, nor does it support uploading.

This CL renames ValueSetOutputFormatter to HistogramSetJsonOutputFormatter, and
re-conceptualizes it as a subclass of Html2OutputFormatter in order to support
converting TBMv1 Values to Histograms and uploading.
The new HistogramSetJsonOutputFormatter now also reads existing results.

HistogramSet JSON Format:
https://docs.google.com/document/d/191rcVi7p4LlV9wFKTM2hCe57R-WpR8O1BccJBpgc-...
Histogram Pipeline:
https://docs.google.com/document/d/169Ez_31h1hzZLM8dtcvZTS3OANkSdGX8X1VNflNv2...

BUG=catapult:#2717
==========

to

==========
Replace ValueSetOutputFormatter with HistogramSetJsonOutputFormatter.

Currently, run_benchmark --output=valueset dumps TBMv2 Histograms to JSON, but
it does not convert TBMv1 Values to Histograms, nor does it read existing
results, nor does it support uploading. Also the name is wrong.

This CL renames ValueSetOutputFormatter to HistogramSetJsonOutputFormatter, and
re-conceptualizes it as a subclass of Html2OutputFormatter in order to support
converting TBMv1 Values to Histograms and uploading.
The new HistogramSetJsonOutputFormatter now also reads existing results.

HistogramSet JSON Format:
https://docs.google.com/document/d/191rcVi7p4LlV9wFKTM2hCe57R-WpR8O1BccJBpgc-...
Histogram Pipeline:
https://docs.google.com/document/d/169Ez_31h1hzZLM8dtcvZTS3OANkSdGX8X1VNflNv2...

BUG=catapult:#2717
==========

[benjhayden, 2016-12-02 19:44:05]

Description was changed from

==========
Replace ValueSetOutputFormatter with HistogramSetJsonOutputFormatter.

Currently, run_benchmark --output=valueset dumps TBMv2 Histograms to JSON, but
it does not convert TBMv1 Values to Histograms, nor does it read existing
results, nor does it support uploading. Also the name is wrong.

This CL renames ValueSetOutputFormatter to HistogramSetJsonOutputFormatter, and
re-conceptualizes it as a subclass of Html2OutputFormatter in order to support
converting TBMv1 Values to Histograms and uploading.
The new HistogramSetJsonOutputFormatter now also reads existing results.

HistogramSet JSON Format:
https://docs.google.com/document/d/191rcVi7p4LlV9wFKTM2hCe57R-WpR8O1BccJBpgc-...
Histogram Pipeline:
https://docs.google.com/document/d/169Ez_31h1hzZLM8dtcvZTS3OANkSdGX8X1VNflNv2...

BUG=catapult:#2717
==========

to

==========
Replace ValueSetOutputFormatter with HistogramSetJsonOutputFormatter.

Currently, run_benchmark --output=valueset dumps TBMv2 Histograms to JSON, but
it does not convert TBMv1 Values to Histograms, nor does it read existing
results, nor does it support uploading. Also the name is wrong.

This CL renames ValueSetOutputFormatter to HistogramSetJsonOutputFormatter, and
re-conceptualizes it as a subclass of Html2OutputFormatter in order to support
converting TBMv1 Values to Histograms and uploading.
The new HistogramSetJsonOutputFormatter now also reads existing results.

go/histogram-set-json-format
go/histogram-pipeline

BUG=catapult:#2717
==========

[benjhayden, 2016-12-02 19:44:15]

Description was changed from

==========
Replace ValueSetOutputFormatter with HistogramSetJsonOutputFormatter.

Currently, run_benchmark --output=valueset dumps TBMv2 Histograms to JSON, but
it does not convert TBMv1 Values to Histograms, nor does it read existing
results, nor does it support uploading. Also the name is wrong.

This CL renames ValueSetOutputFormatter to HistogramSetJsonOutputFormatter, and
re-conceptualizes it as a subclass of Html2OutputFormatter in order to support
converting TBMv1 Values to Histograms and uploading.
The new HistogramSetJsonOutputFormatter now also reads existing results.

go/histogram-set-json-format
go/histogram-pipeline

BUG=catapult:#2717
==========

to

==========
Replace ValueSetOutputFormatter with HistogramSetJsonOutputFormatter.

Currently, run_benchmark --output=valueset dumps TBMv2 Histograms to JSON, but
it does not convert TBMv1 Values to Histograms, nor does it read existing
results, nor does it support uploading. Also the name is wrong.

This CL renames ValueSetOutputFormatter to HistogramSetJsonOutputFormatter, and
re-conceptualizes it as a subclass of Html2OutputFormatter in order to support
converting TBMv1 Values to Histograms and uploading.
The new HistogramSetJsonOutputFormatter now also reads existing results.

http://go/histogram-set-json-format
http://go/histogram-pipeline

BUG=catapult:#2717
==========

[benjhayden, 2016-12-02 19:47:58]

benjhayden@chromium.org changed reviewers:
+ eakuefner@chromium.org

[benjhayden, 2016-12-02 19:47:59]

PTAL :-)

Should this go to telemetry-announce?

[eakuefner, 2016-12-02 21:56:10]

Hmm... does it seem like Html2OutputFormatter should actually be a subclass of
HistogramSetJsonOutputFormatter and not the other way around?

[eakuefner, 2016-12-02 21:56:32]

On 2016/12/02 at 19:47:59, benjhayden wrote:
> PTAL :-)
> 
> Should this go to telemetry-announce?

Yes, once we agree on the approach.

[benjhayden, 2016-12-02 23:31:17]

On 2016/12/02 at 21:56:10, eakuefner wrote:
> Hmm... does it seem like Html2OutputFormatter should actually be a subclass of
HistogramSetJsonOutputFormatter and not the other way around?

Maybe? :-)
Why does that seem more natural?
The only reason I'm pushing back is because that would make the patch larger and
mean more typing for me. :-)

[eakuefner, 2016-12-05 21:56:30]

lgtm

Eliminate subclassing as discussed.

[benjhayden, 2016-12-05 21:56:35]

https://codereview.chromium.org/2538043005/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/results/html2_output_formatter.py (right):

https://codereview.chromium.org/2538043005/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/results/html2_output_formatter.py:29: def
ConvertChartJson_(self, page_test_results):
Factor to PageTestResults.AsHistogramDicts()

https://codereview.chromium.org/2538043005/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/results/html2_output_formatter.py:61: file_path =
os.path.abspath(self._output_stream.name)
Factor to function in a new module

[benjhayden, 2016-12-06 18:05:03]

Done. Want to take another look? Should Ned review?

[benjhayden, 2016-12-07 00:38:16]

The CQ bit was checked by benjhayden@chromium.org

[benjhayden, 2016-12-07 00:38:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org
Link to the patchset: https://codereview.chromium.org/2538043005/#ps80001
(title: "fix reading existing histograms json")

[commit-bot: I haz the power, 2016-12-07 00:38:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 00:53:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 00:53:32]

Try jobs failed on following builders:
  Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma...)

[benjhayden, 2016-12-07 16:51:05]

The CQ bit was checked by benjhayden@chromium.org

[benjhayden, 2016-12-07 16:51:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org
Link to the patchset: https://codereview.chromium.org/2538043005/#ps50008
(title: "fix test")

[commit-bot: I haz the power, 2016-12-07 16:51:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 17:52:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 17:52:12]

Try jobs failed on following builders:
  Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Li...)

[benjhayden, 2016-12-07 18:04:12]

The CQ bit was checked by benjhayden@chromium.org

[benjhayden, 2016-12-07 18:04:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org
Link to the patchset: https://codereview.chromium.org/2538043005/#ps110001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-07 18:04:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 18:26:18]

CQ is committing da patch.

Bot data: {"patchset_id": 110001, "attempt_start_ts": 1481133852802830,
"parent_rev": "d410f5a085c4afb4372916b61f32a9c9a548f35d", "commit_rev":
"77ad967bf0a4a9358d57fe42a6fd2a83a422ff49"}

[commit-bot: I haz the power, 2016-12-07 18:26:22]

Description was changed from

==========
Replace ValueSetOutputFormatter with HistogramSetJsonOutputFormatter.

Currently, run_benchmark --output=valueset dumps TBMv2 Histograms to JSON, but
it does not convert TBMv1 Values to Histograms, nor does it read existing
results, nor does it support uploading. Also the name is wrong.

This CL renames ValueSetOutputFormatter to HistogramSetJsonOutputFormatter, and
re-conceptualizes it as a subclass of Html2OutputFormatter in order to support
converting TBMv1 Values to Histograms and uploading.
The new HistogramSetJsonOutputFormatter now also reads existing results.

http://go/histogram-set-json-format
http://go/histogram-pipeline

BUG=catapult:#2717
==========

to

==========
Replace ValueSetOutputFormatter with HistogramSetJsonOutputFormatter.

Currently, run_benchmark --output=valueset dumps TBMv2 Histograms to JSON, but
it does not convert TBMv1 Values to Histograms, nor does it read existing
results, nor does it support uploading. Also the name is wrong.

This CL renames ValueSetOutputFormatter to HistogramSetJsonOutputFormatter, and
re-conceptualizes it as a subclass of Html2OutputFormatter in order to support
converting TBMv1 Values to Histograms and uploading.
The new HistogramSetJsonOutputFormatter now also reads existing results.

http://go/histogram-set-json-format
http://go/histogram-pipeline

BUG=catapult:#2717

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-12-07 18:26:23]

Committed patchset #7 (id:110001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

[eakuefner, 2016-12-07 18:36:12]

A revert of this CL (patchset #7 id:110001) has been created in
https://codereview.chromium.org/2556213002/ by eakuefner@chromium.org.

The reason for reverting is: Please send an email to telemetry-announce before
landing this. Also, results_options is not the right place for the uploading
logic..

[eakuefner, 2016-12-07 18:40:51]

Before re-landing, can we figure out why HistogramSetJsonOutputFormatter needs
to be able to upload results? My best guess is that it does not; the uploading
functionality is to service perf tryjobs, which upload HTML results to cloud
storage.