telemetry/telemetry/internal/results/html_output_formatter_unittest.py - Issue 2538043005: Replace ValueSetOutputFormatter with HistogramSetJsonOutputFormatter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/results/html_output_formatter_unittest.py

Issue 2538043005: Replace ValueSetOutputFormatter with HistogramSetJsonOutputFormatter. (Closed)

Patch Set: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/results/html_output_formatter.py ('k') | telemetry/telemetry/internal/results/output_formatter.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/results/html_output_formatter_unittest.py

diff --git a/telemetry/telemetry/internal/results/html_output_formatter_unittest.py b/telemetry/telemetry/internal/results/html_output_formatter_unittest.py

index 198d961501046a42aaaf905a21ff09394ba211f5..9a460e38e5829bce0a9b382a1dda2df3a373fec3 100644

--- a/telemetry/telemetry/internal/results/html_output_formatter_unittest.py

+++ b/telemetry/telemetry/internal/results/html_output_formatter_unittest.py

@@ -67,7 +67,7 @@ class HtmlOutputFormatterTest(unittest.TestCase):

results.DidRunPage(test_story_set.stories[1])

formatter = DeterministicHtmlOutputFormatter(

- output_file, FakeMetadataForTest(), False, False, 'browser_type')

+ output_file, FakeMetadataForTest(), False, 'browser_type')

formatter.Format(results)

expected = {

"platform": "browser_type",

@@ -121,7 +121,7 @@ class HtmlOutputFormatterTest(unittest.TestCase):

results.DidRunPage(test_story_set.stories[1])

formatter = DeterministicHtmlOutputFormatter(

- output_file, FakeMetadataForTest(), False, False, 'browser_type')

+ output_file, FakeMetadataForTest(), False, 'browser_type')

formatter.Format(results)

expected = [

{

@@ -213,7 +213,7 @@ class HtmlOutputFormatterTest(unittest.TestCase):

results.DidRunPage(test_story_set.stories[1])

formatter = DeterministicHtmlOutputFormatter(

- output_file, FakeMetadataForTest(), True, False, 'browser_type')

+ output_file, FakeMetadataForTest(), True, 'browser_type')

formatter.Format(results)

expected = [{

"platform": "browser_type",