Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: components/browser_sync/profile_sync_service_unittest.cc

Issue 2538023002: [Sync] Pass a TaskRunner into SBHI/SBHC, not a thread or message loop. (Closed)
Patch Set: Remove thread check in destructor. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/browser_sync/profile_sync_service.cc ('k') | components/sync/driver/glue/sync_backend_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/browser_sync/profile_sync_service_unittest.cc
diff --git a/components/browser_sync/profile_sync_service_unittest.cc b/components/browser_sync/profile_sync_service_unittest.cc
index 6832d2cc173abf0c8f35fa5019eefb95f128ded5..be4ced19fe7d66962b58d524ad646cc23d60a1a3 100644
--- a/components/browser_sync/profile_sync_service_unittest.cc
+++ b/components/browser_sync/profile_sync_service_unittest.cc
@@ -105,7 +105,7 @@ class TestSyncServiceObserver : public syncer::SyncServiceObserver {
class SyncBackendHostNoReturn : public SyncBackendHostMock {
void Initialize(
syncer::SyncFrontend* frontend,
- base::Thread* sync_thread,
+ scoped_refptr<base::SingleThreadTaskRunner> sync_task_runner,
const syncer::WeakHandle<syncer::JsEventHandler>& event_handler,
const GURL& service_url,
const std::string& sync_user_agent,
@@ -130,7 +130,7 @@ class SyncBackendHostMockCollectDeleteDirParam : public SyncBackendHostMock {
void Initialize(
syncer::SyncFrontend* frontend,
- base::Thread* sync_thread,
+ scoped_refptr<base::SingleThreadTaskRunner> sync_task_runner,
const syncer::WeakHandle<syncer::JsEventHandler>& event_handler,
const GURL& service_url,
const std::string& sync_user_agent,
@@ -147,11 +147,12 @@ class SyncBackendHostMockCollectDeleteDirParam : public SyncBackendHostMock {
saved_nigori_state) override {
delete_dir_param_->push_back(delete_sync_data_folder);
SyncBackendHostMock::Initialize(
- frontend, sync_thread, event_handler, service_url, sync_user_agent,
- credentials, delete_sync_data_folder, enable_local_sync_backend,
- local_sync_backend_folder, std::move(sync_manager_factory),
- unrecoverable_error_handler, report_unrecoverable_error_function,
- http_post_provider_factory_getter, std::move(saved_nigori_state));
+ frontend, std::move(sync_task_runner), event_handler, service_url,
+ sync_user_agent, credentials, delete_sync_data_folder,
+ enable_local_sync_backend, local_sync_backend_folder,
+ std::move(sync_manager_factory), unrecoverable_error_handler,
+ report_unrecoverable_error_function, http_post_provider_factory_getter,
+ std::move(saved_nigori_state));
}
private:
« no previous file with comments | « components/browser_sync/profile_sync_service.cc ('k') | components/sync/driver/glue/sync_backend_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698