components/browser_sync/profile_sync_service.cc - Issue 2538023002: [Sync] Pass a TaskRunner into SBHI/SBHC, not a thread or message loop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/browser_sync/profile_sync_service.cc

Issue 2538023002: [Sync] Pass a TaskRunner into SBHI/SBHC, not a thread or message loop. (Closed)

Patch Set: Remove thread check in destructor. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/browser_sync/profile_sync_service.cc

diff --git a/components/browser_sync/profile_sync_service.cc b/components/browser_sync/profile_sync_service.cc

index 27f579955fad3ad8ffbd9e6c38ecf40808105b26..7cbe502b1b599459b0288eef0e0728695f71332d 100644

--- a/components/browser_sync/profile_sync_service.cc

+++ b/components/browser_sync/profile_sync_service.cc

@@ -543,7 +543,7 @@ void ProfileSyncService::InitializeBackend(bool delete_stale_data) {

url_request_context_, network_time_update_callback_);

backend_->Initialize(

- this, sync_thread_.get(), GetJsEventHandler(), sync_service_url_,

+ this, sync_thread_->task_runner(), GetJsEventHandler(), sync_service_url_,

local_device_->GetSyncUserAgent(), credentials, delete_stale_data,

enable_local_sync_backend, local_sync_backend_folder,

base::MakeUnique<syncer::SyncManagerFactory>(),